Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

view: reorganize planner components #4348

Merged
merged 4 commits into from
May 7, 2024
Merged

view: reorganize planner components #4348

merged 4 commits into from
May 7, 2024

Conversation

TalDerei
Copy link
Collaborator

@TalDerei TalDerei commented May 7, 2024 •
edited
Loading

Describe your changes

Reorganize the ActionList struct, enabling the web code to use the same structure when updating its rust dependencies.

Issue ticket number and link

References #4332

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

@TalDerei TalDerei self-assigned this May 7, 2024
@TalDerei TalDerei marked this pull request as ready for review May 7, 2024 20:53
@TalDerei TalDerei requested review from hdevalence and erwanor May 7, 2024 20:56
@TalDerei
Copy link
Collaborator Author

TalDerei commented May 7, 2024

@conorsch can you cherry pick this PR (on merge) into the point release?

hdevalence
hdevalence approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but it won't be cherry-pickable onto an 0.73.x point release because it's built on top of breaking API changes. Instead we should include it in an 0.74.0 upgrade release.

cratelyn
cratelyn approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cratelyn cratelyn added this to the Sprint 6 milestone May 7, 2024
@TalDerei TalDerei merged commit 0ceb758 into main May 7, 2024
13 checks passed
@TalDerei TalDerei deleted the modify-planner branch May 7, 2024 21:46
@cratelyn cratelyn added A-client Area: Design and implementation for client functionality C-refactor Category: refactors and other related improvements labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cratelyn cratelyn cratelyn approved these changes

@hdevalence hdevalence hdevalence approved these changes

@erwanor erwanor Awaiting requested review from erwanor

Assignees

@TalDerei TalDerei

Labels
A-client Area: Design and implementation for client functionality C-refactor Category: refactors and other related improvements
Projects
Penumbra
Status: Done
Milestone
Sprint 6
Development

Successfully merging this pull request may close these issues.
3 participants
@TalDerei @hdevalence @cratelyn