ibc: handle height in gRPC request metadata if specified #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
reviewed
Dec 3, 2024
| debug!("height header was missing; assuming a height of 0"); | ||
| Ok(TheHeight::zero().into_inner()) | ||
| } | ||
| Some(entry) => entry |
There was a problem hiding this comment.
We can use the ibc-types-core-client::Height type and avoid the newtyping. With that said, I think we should just merge this, and then favor using the new messages once those become available: cosmos/ibc-go#7303
|
Thanks a lot, learned a bunch from going down this rabbit hole. I am doing some testing and will merge EOD or early tomorrow. |
conorsch
added a commit
to penumbra-zone/hermes
that referenced
this pull request
Dec 5, 2024
Updates the penumbra deps to commit [0] on main branch, including merge of [1]. The naive dep update breaks builds, so further changes are required. [0] ac7abacc9bb09503d6fd6a396bc0b6850079084e [1] penumbra-zone/penumbra#4905
This was referenced Dec 5, 2024
conorsch
added a commit
to penumbra-zone/hermes
that referenced
this pull request
Dec 6, 2024
Bumping the Penumbra dependencies to v0.80.x, specifically on the current main branch of the protocol repo. Ideally we'd tag a v0.80.10, containing fixes from penumbra-zone/penumbra#4905, but we haven't done that just yet. Notably, the bump in Penumbra protocol deps will involve a schema change for the view database. I haven't tested locally yet, but I expect Hermes when upgraded to throw an error about the view schema mismatch. If and when that happens during interactive testing on the testnet, I'll make sure to document those errors so we can communicate the need to perform maintenance to operators.
6 tasks
2 tasks
conorsch
pushed a commit
that referenced
this pull request
Dec 10, 2024
## Describe your changes This PR: - instruments IBC gRPC spans on `DEBUG` - prefer using the `HostInterface` trait to hardcoding height/revision for gRPC responses - systematically defer to the query height hint (in the gRPC headers) for **every API that returns a proof** (extending #4905, cc @noot) We will be able to rip out all of the header selection logic once `https://github.com/cosmos/ibc-go/pull/7303` is merged. ## Checklist before requesting a review - [ ] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > RPC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Check if height is specified in the metadata for relevant IBC gRPC queries and get the respective snapshot if it is provided. If the height is not specified in the metadata, the latest snapshot is used, which is the existing behaviour.
Reasoning: since astria uses only gRPC queries for all the IBC queries in the hermes impl, but the gRPC proto messages don't contain the query height, we implemented a fix by putting the height in the metadata. Without this fix, our hermes impl would submit unexpected proofs on occasion, as the proofs would be off-by-one height than that was expected.
I opened a PR to update the protos, but the response by the maintainer of ibc-go suggests to me that they intend for having the height in the header be the actual fix (cosmos/ibc-go#7303).
Issue ticket number and link
n/a
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: