wip: generate test vectors for expected hardware wallet UI output #4948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
Previously, we were generating the addresses randomly. This is good for some cases but there are situations where we have different expected behavior if the address is controlled by the user: 1. In an `Ics20Withdrawal`, we want a return address controlled by the user, else fail to sign. 2. In a `Swap`, the claim address should be controlled by the user, else fail to sign.
Tier 1 actions are: Spend, Output, Swap, Ics20Withdrawal Note there is NO output for the other actions yet.
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Work towards generating screens for hardware wallet UI output from our
EffectHashtransaction plans added in #4879Caveats:
PANIC [X/X] : LEDGER SHOULD REFUSE TO SIGNalong with the reason, e.g.PANIC [X/X] : LEDGER SHOULD REFUSE TO SIGN (return address in Ics20Withdrawal not controlled by user).Spend,Output,Ics20WithdrawalandSwap. The other action outputs are not yet implemented, and so there will be no output for those actions.Issue ticket number and link
Closes #4947
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: