Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(planner): correctly handle non-zero fees #876

Closed
TalDerei opened this issue Apr 3, 2024 · 2 comments
Closed

refactor(planner): correctly handle non-zero fees #876

TalDerei opened this issue Apr 3, 2024 · 2 comments
Assignees
@TalDerei
Labels
bug Something isn't working deps update Update of project dependencies refactor Improving existing system with new design wasm Rust crate updates

Comments

@TalDerei
Copy link
Contributor

TalDerei commented Apr 3, 2024 •
edited
Loading

Currently, the way we balance a transaction following #609 is not entirely correct in the presence non-zero fees for swap-claims. This will remain blocked until penumbra-zone/penumbra#4141 lands, and we can upstream some of the same changes to the wasm planner the next time the rust deps are updated.

cc @grod220 @hdevalence @conorsch
@TalDerei TalDerei added refactor Improving existing system with new design wasm Rust crate updates labels Apr 3, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Apr 3, 2024
@TalDerei TalDerei added bug Something isn't working mainnet and removed bug Something isn't working labels Apr 3, 2024
@TalDerei TalDerei self-assigned this Apr 3, 2024
@TalDerei TalDerei mentioned this issue Apr 4, 2024
Closed
@grod220 grod220 moved this from 🗄️ Backlog to 📝 Todo in Penumbra web Apr 4, 2024
@TalDerei TalDerei moved this from 📝 Todo to 🛑 Blocked in Penumbra web Apr 18, 2024
@TalDerei TalDerei mentioned this issue Apr 24, 2024
Closed
@TalDerei TalDerei moved this from 🛑 Blocked to 📝 Todo in Penumbra web Apr 25, 2024
@TalDerei TalDerei removed the on-hold label Apr 25, 2024
@TalDerei
Copy link
Contributor Author

TalDerei commented May 3, 2024

tagging penumbra-zone/penumbra#4313 for visibility

@TalDerei TalDerei moved this from 📝 Todo to 🏗 In progress in Penumbra web May 4, 2024
@TalDerei TalDerei moved this from 🏗 In progress to 📝 Todo in Penumbra web May 5, 2024
@TalDerei
Copy link
Contributor Author

TalDerei commented May 7, 2024 •
edited
Loading

blocked by penumbra-zone/penumbra#4332

This was referenced May 7, 2024
Closed
Closed
@TalDerei TalDerei moved this from 📝 Todo to 🏗 In progress in Penumbra web May 7, 2024
@TalDerei TalDerei mentioned this issue May 10, 2024
Merged
@TalDerei TalDerei added bug Something isn't working deps update Update of project dependencies labels May 10, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra web May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TalDerei TalDerei

Labels
bug Something isn't working deps update Update of project dependencies refactor Improving existing system with new design wasm Rust crate updates
Projects
Penumbra web
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TalDerei