-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ActionList
from view
crate into transaction
crate
#4332
Comments
Sounds great. If we do this part, the next time the web repo updates its rust deps, we'll be able to commonize the fee handling behavior between the two planner implementations. |
@hdevalence this needs to be prioritized to fix swap-claim bug identified in penumbra-zone/web#1054. Then we can propagate the changes in penumbra-zone/web#876. |
sounds great, want to take it on? |
@aubrika can you add this to current sprint? |
## Describe your changes Reorganize the `ActionList` struct, enabling the web code to use the same structure when updating its rust dependencies. ## Issue ticket number and link References #4332 ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
Is your feature request related to a problem? Please describe.
The
ActionList
introduced in #4319 represents an in-progress list of actions that will be turned into aTransactionPlan
, and provides helper methods for balancing the value of those actions, making it the core of a planner implementation. It should be shared between both planners.Describe the solution you'd like
Remove the current
view/src/planner/action_list.rs
, redistributing its contents:prioritize_and_filter_spendable_notes
function should move up into the parent module of theview
cratetransaction/src/action_list.rs
and be exposed as anaction_list
submodule of thetransaction
crateThen update the existing code to match the changed imports.
Additional context
This allows the web code to use the same
ActionList
.The text was updated successfully, but these errors were encountered: