Account for Dutch auction schedules/ends in the WASM planner #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
changed the title
jessepinho
requested review from
TalDerei,
erwanor,
grod220,
Valentine1898 and
turbocrime
erwanor
reviewed
May 1, 2024
grod220
approved these changes
May 1, 2024
TalDerei
approved these changes
May 1, 2024
| })); | ||
| } | ||
|
|
||
| // TODO: Handle Dutch auction withdraws |
There was a problem hiding this comment.
can you open a separate issue to track withdraws in the planner?
|
References #978 |
Base automatically changed from
jessepinho/block-processor-auctions-web-942
to
main
May 2, 2024 21:19
* Build out Dutch auction UI * Add more docs to Slider * Fix metadata * Rename Prices -> Price * Fix test name * Create first tests for assembleRequest * Add one more test * Tweak Price layout * Add auction to swap sublinks * Remove tabs for now * Convert to a Record to avoid having to assert presence * Change min output * Change to decimal * Align to the right * Handle exponent when processing amounts * Add test coverage for constants
jessepinho
force-pushed
the
jessepinho/auctions-wasm-planner-web-942
branch
from
872d918 to
bf9f011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to split out PRs related to #942 into smaller, reviewable chunks.
This PR accounts for
ActionDutchAuctionScheduleandActionDutchAuctionEndactions in a transaction planner request. Thanks to @TalDerei for pairing with me on this.