Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent listener race condition #2062

Closed
wants to merge 2 commits into from
Closed

Prevent listener race condition #2062

wants to merge 2 commits into from

Conversation

turbocrime
Copy link
Collaborator

Prevent race conditions discovered in implementation of session-client-reconnect.

Thoroughly manage port state at all locations.

  • I have ensured that any relevant minifront changes do not cause the existing extension to break.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: cb96065

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@turbocrime turbocrime force-pushed the prevent-listener-race-condition branch 2 times, most recently from 5598912 to 8d91531 Compare February 19, 2025 04:50
@turbocrime turbocrime force-pushed the session-client-reconnect branch 2 times, most recently from b394c6f to 927ac8d Compare February 19, 2025 05:34
@turbocrime turbocrime force-pushed the prevent-listener-race-condition branch from 8d91531 to 53b6756 Compare February 19, 2025 05:41
@turbocrime turbocrime mentioned this pull request Feb 19, 2025
Open
12 tasks
@turbocrime turbocrime force-pushed the session-client-reconnect branch from 927ac8d to d880369 Compare February 19, 2025 05:54
Base automatically changed from session-client-reconnect to connection-lifecycle-branch February 19, 2025 06:11
@turbocrime turbocrime force-pushed the prevent-listener-race-condition branch from 53b6756 to 76a7635 Compare February 19, 2025 06:13
@turbocrime turbocrime force-pushed the prevent-listener-race-condition branch from 76a7635 to 379fe7d Compare February 19, 2025 06:15
@turbocrime turbocrime mentioned this pull request Feb 19, 2025
Open
3 tasks
@TalDerei TalDerei self-requested a review February 19, 2025 15:04
@TalDerei TalDerei marked this pull request as ready for review February 19, 2025 15:04
TalDerei
TalDerei approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@TalDerei TalDerei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't able to repro the race condition on slower public wifi, and don't fully understand all the justifications here, but discussed out of band about the assurance testing you performed on this.

@turbocrime
Copy link
Collaborator Author

closing in favor of #2066

@turbocrime turbocrime closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalDerei TalDerei TalDerei approved these changes

Assignees

@turbocrime turbocrime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbocrime @TalDerei