Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock chrome messaging, implement tests for transport-chrome, improve tests for transport-dom #2067

Merged
merged 12 commits into from
Feb 26, 2025

Conversation

turbocrime
Copy link
Collaborator

@turbocrime turbocrime commented Feb 20, 2025

PR including tests implemented for transport-chrome and transport-dom

Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: 935894c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@penumbra-zone/transport-chrome Patch
@penumbra-zone/transport-dom Patch
minifront Patch
@penumbra-zone/client Patch
@penumbra-zone/services Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TalDerei TalDerei self-requested a review February 21, 2025 20:46
Copy link
Contributor

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed out of band, looks good to me after green CI!

can we add a changeset here for npm publishing?

@turbocrime turbocrime changed the title Mock chrome messaging, implement tests for transport-chrome Mock chrome messaging, implement tests for transport-chrome, improve tests for transport-dom Feb 25, 2025
@turbocrime turbocrime merged commit ca71c02 into main Feb 26, 2025
6 checks passed
@turbocrime turbocrime deleted the mock-chrome branch February 26, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants