EVEREST-107 | WIP #896
EVEREST-107 | WIP #896
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| import ( | ||
| "net/http" | ||
| "reflect" | ||
|
|
||
| "github.com/AlekSi/pointer" | ||
| "github.com/labstack/echo/v4" | ||
| . "github.com/percona/everest/api" |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/percona/everest) (gci)
|
|
||
| import ( | ||
| . "github.com/percona/everest/api" | ||
| "net/http" | ||
| "slices" | ||
| "strings" |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
File is not gofumpt-ed (gofumpt)
| @@ -26,6 +26,7 @@ import ( | |||
| "github.com/cenkalti/backoff/v4" | |||
| goversion "github.com/hashicorp/go-version" | |||
| "github.com/labstack/echo/v4" | |||
| . "github.com/percona/everest/api" | |||
| "golang.org/x/net/context" | |||
| "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" | |||
|
|
|||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
File is not goimports-ed with -local github.com/percona/everest (goimports)
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
File is not goimports-ed with -local github.com/percona/everest (goimports)
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
File is not goimports-ed with -local github.com/percona/everest (goimports)
everest/internal/server/middlewares.go
Line 23 in 297ac36
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
mayankshah1607
force-pushed
the
EVEREST-107-api-refactoring
branch
from
297ac36 to
db48049
Compare
| "errors" | ||
| "fmt" | ||
|
|
||
| "github.com/casbin/casbin/v2" |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/percona/everest) (gci)
| "github.com/percona/everest/api" | ||
| "github.com/percona/everest/internal/server/handlers" | ||
| "github.com/percona/everest/pkg/kubernetes" | ||
| "go.uber.org/zap" |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/percona/everest) (gci)
| @@ -0,0 +1,82 @@ | |||
| package handlers | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
package-comments: should have a package comment (revive)
| @@ -0,0 +1,27 @@ | |||
| package rbac | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
package-comments: should have a package comment (revive)
| "github.com/percona/everest/api" | ||
| ) | ||
|
|
||
| func (h *rbacHandler) ListDatabaseEngines(ctx context.Context, user, namespace string) (*api.DatabaseEngineList, error) { |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
| } | ||
|
|
||
| func (h *rbacHandler) ListDatabaseClusters(ctx context.Context, user, namespace string) (*api.DatabaseClusterList, error) { | ||
| return nil, nil |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
return both the nil error and invalid value: use a sentinel error instead (nilnil)
| } | ||
|
|
||
| func (h *rbacHandler) GetDatabaseCluster(ctx context.Context, user, namespace, name string) (*api.DatabaseCluster, error) { | ||
| return nil, nil |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
return both the nil error and invalid value: use a sentinel error instead (nilnil)
| @@ -0,0 +1,39 @@ | |||
| package rbac | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
ST1000: at least one file in a package should have a package comment (stylecheck)
| @@ -0,0 +1,23 @@ | |||
| package rbac | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
ST1000: at least one file in a package should have a package comment (stylecheck)
| @@ -0,0 +1,27 @@ | |||
| package rbac | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
ST1000: at least one file in a package should have a package comment (stylecheck)
| @@ -42,6 +40,7 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/client" | |||
| "sigs.k8s.io/controller-runtime/pkg/client/apiutil" | |||
|
|
|||
| . "github.com/percona/everest/api" | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
dot-imports: should not use dot imports (revive)
| @@ -14,9 +14,7 @@ | |||
| // limitations under the License. | |||
|
|
|||
| // Package api contains the API server implementation. | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
package-comments: package comment should be of the form "Package server ..." (revive)
| @@ -29,6 +29,7 @@ import ( | |||
| "k8s.io/apimachinery/pkg/runtime" | |||
|
|
|||
| everestv1alpha1 "github.com/percona/everest-operator/api/v1alpha1" | |||
| . "github.com/percona/everest/api" | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
dot-imports: should not use dot imports (revive)
| @@ -14,7 +14,7 @@ | |||
| // limitations under the License. | |||
|
|
|||
| // Package api contains the API server implementation. | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
package-comments: package comment should be of the form "Package server ..." (revive)
| @@ -14,14 +14,15 @@ | |||
| // limitations under the License. | |||
|
|
|||
| // Package api ... | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
package-comments: package comment should be of the form "Package server ..." (revive)
No description provided.