This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
EVEREST-444 Add configurable bind address for the everest container #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In EVEREST-333 (#142) we identified and fixed a security vulnerability where we were exposing everest's port to 0.0.0.0 by default.
However, this fix broke the ability for users to access everest from outside localhost which is must have.
Related pull requests
Cause:
#142
Solution:
Add a
EVEREST_BIND_ADDR
env var which is127.0.0.1
by default but allows for users to control the bind address and thus the exposure of the everest container.CHECKLIST
Jira
Tests
[ ] Is an Integration test/test case added for the new feature/change?[ ] Are unit tests added where appropriate?