Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

EVEREST-302 Improve validation for backupStorage #169

Closed
wants to merge 3 commits into from
Closed

Conversation

gen1us2k
Copy link
Contributor

@gen1us2k gen1us2k commented Sep 19, 2023

EVEREST-302 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
EVEREST-302

Short explanation of the problem.

Related pull requests

  • [link]

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

api/backup_storage.go Outdated Show resolved Hide resolved
@oksana-grishchenko
Copy link
Contributor

That makes API a bit weird. Why do we have exactly that 3 parameters required? It doesn't really solve the original problem described in the ticket, I mean, what if I'll do a request with the "regioon" instead of "region"? I also have a concern about the FE compatibility. We need to make sure that it's not gonna break the existing integration before 0.3 or we need to create a FE ticket for this.

Not sure we need to address the original problem though since we have the openAPI spec that describes the correct field names.

@gen1us2k
Copy link
Contributor Author

I'm not sure either but this PR was a low-effort stuff so I decided to discuss it with you. I'll talk to QA team

@gen1us2k gen1us2k closed this Sep 20, 2023
@gen1us2k gen1us2k deleted the EVEREST-302 branch September 20, 2023 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants