Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

EVEREST-434 move to errors package #171

Merged
merged 7 commits into from
Sep 21, 2023
Merged

EVEREST-434 move to errors package #171

merged 7 commits into from
Sep 21, 2023

Conversation

gen1us2k
Copy link
Contributor

@gen1us2k gen1us2k commented Sep 20, 2023

EVEREST-434 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
EVEREST-434

Short explanation of the problem.
pkg/errors was deprecated a couple of years ago

Related pull requests

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

The provided solution does not violate Go's standard error handling principles and implements a custom Marshaller to capitalize error messages

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

api/marshal.go Outdated Show resolved Hide resolved
@gen1us2k gen1us2k marked this pull request as ready for review September 20, 2023 19:51
@gen1us2k gen1us2k requested a review from a user September 20, 2023 19:51
Copy link
Contributor

@oksana-grishchenko oksana-grishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg/errors still can be found in go.mod and tests
Screenshot 2023-09-20 at 23 39 53

@gen1us2k
Copy link
Contributor Author

@oksana-grishchenko migrated tests but it's present in mod files because dependencies use it

api/validation_test.go Show resolved Hide resolved
api/validation_test.go Show resolved Hide resolved
api/validation_test.go Outdated Show resolved Hide resolved
api/validation_test.go Show resolved Hide resolved
api/validation_test.go Show resolved Hide resolved
api/validation_test.go Outdated Show resolved Hide resolved
@gen1us2k gen1us2k enabled auto-merge (squash) September 21, 2023 09:51
@gen1us2k gen1us2k merged commit 69fb781 into main Sep 21, 2023
4 checks passed
@gen1us2k gen1us2k deleted the EVEREST-434 branch September 21, 2023 10:04
pkg/kubernetes/configs.go Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants