EVEREST-482 Removed nolint:funlen,cyclop directives

[gen1us2k]

CHANGE DESCRIPTION

Problem:
EVEREST-482

Short explanation of the problem.
We shut some linters intentionally in the past

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

The linter complains about cyclomatic complexity of 11 or 12 and I didn't see any other option instead of increasing this to 15. 15 is good enough and I had the setting for 30 in the past. Having the default setting for funlen and max-complexity set to 15 will prevent us from writing huge functions.

I refactored functions that had funlen issues but the rest of functions with //nolint:cyclop they had a cyclomatic complexity of 11 or 12 and there's no sane way to refactor them

CHECKLIST

Jira

• Is the Jira ticket created and referenced properly?

Tests

• Is an Integration test/test case added for the new feature/change?
• Are unit tests added where appropriate?

[recharte]

Can we start being strict with the PR description from now on? I'm seeing many PRs being opened with the default template.
I know that this particular PR doesn't add any new functionality or fix any bug but if we slack on these PRs we'll start slacking on any PR. Let's do a team effort to fill the template correctly for every PR.

[gen1us2k]

Can we start being strict with the PR description from now on? I'm seeing many PRs being opened with the default template.
I know that this particular PR doesn't add any new functionality or fix any bug but if we slack on these PRs we'll start slacking on any PR. Let's do a team effort to fill the template correctly for every PR.

I agree. I was in the middle of filling it

[oksana-grishchenko]

I thinks it's still ok to have 15 as max complexity. In case of API method handlers we need to do many different things in it and sometimes splitting the method into smaller brings more confusion than if we have all logic plain.