This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
EVEREST-478 Flaky tests #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gen1us2k
approved these changes
Oct 2, 2023
ghost
reviewed
Oct 2, 2023
Comment on lines
188
to
199
| let list = await response.json() | ||
|
|
||
| expect(list.filter((i) => i.name.startsWith(`${namePrefix}${testPrefix}`)).length).toBe(3) | ||
|
|
||
| response = await request.delete(`/v1/monitoring-instances/${name}`) | ||
| expect(response.ok()).toBeTruthy() | ||
|
|
||
| response = await request.get('/v1/monitoring-instances') | ||
| expect(response.ok()).toBeTruthy() | ||
| list = await response.json() | ||
|
|
||
| expect(list.filter((i) => i.name.startsWith(`${namePrefix}${testPrefix}`)).length).toBe(2) |
There was a problem hiding this comment.
This logic was in place intentionally.
I discovered we had a bug in the implementation where delete would delete the first instance, not the one selected by name.
I suggest we keep this in place.
There was a problem hiding this comment.
Thanks for pointing that corner case out! The test is updated to handle it again. Also added a comment to avoid such confusions in the future.
ghost
approved these changes
Oct 3, 2023
| }) | ||
|
|
||
| test('get monitoring instance', async ({ request }) => { | ||
| const namePrefix = 'get-' |
There was a problem hiding this comment.
This was in place for the same purpose - making sure we don't return the first entry instead of the correct one.
|
not relevant anymore, fixed by #431 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky tests
Problem:
EVEREST-478
In the backend repo there are several flaky tests for monitoring and backup-storages
Solution
Add random naming and cleanup