EVEREST-301 Shorten the error message for backup storage creation

api-tests/tests/backup-storages.spec.ts

@@ -142,7 +142,7 @@ test('create backup storage failures', async ({ request }) => {
         accessKey: 'ssdssd',
         secretKey: 'ssdssdssdssd',
       },
-      errorText: 'Could not connect to the backup storage, please check the new credentials are correct',
+      errorText: `Creating storage is not implemented for 'azure'`,
     },
   ]
 

api/backup_storage.go

@@ -249,13 +249,11 @@
 		if errors.Is(err, gorm.ErrRecordNotFound) {
 			return ctx.JSON(http.StatusNotFound, Error{Message: pointer.ToString("Could not find backup storage")})
 		}
-		if errors.Is(err, errUserFacingMsg) {
-			return ctx.JSON(http.StatusBadRequest, Error{
-				Message: pointer.ToString(fmt.Sprintf("Could not connect to the backup storage, please check the new credentials are correct: %s", err)),
-			})
-		}
+		return ctx.JSON(http.StatusBadRequest, Error{
+			Message: pointer.ToString(fmt.Sprintf("Could not connect to the backup storage, please check the new credentials are correct: %s", err)),
+		})
 
 		e.l.Error(err)
 		return ctx.JSON(http.StatusBadRequest, Error{
 			Message: pointer.ToString("Could not connect to the backup storage, please check the new credentials are correct"),
 		})

api/everest.go

@@ -53,10 +53,6 @@ type EverestServer struct {
 	echo           *echo.Echo
 }
 
-// errUserFacingMsg represents an error with a message which can be returned
-// back to the user directly without any modification.
-var errUserFacingMsg = errors.New("")
-
 // NewEverestServer creates and configures everest API.
 func NewEverestServer(c *config.EverestConfig, l *zap.SugaredLogger) (*EverestServer, error) {
 	e := &EverestServer{

api/validation.go

@@ -185,7 +185,8 @@ func s3Access(l *zap.SugaredLogger, endpoint *string, accessKey, secretKey, buck
 		Credentials: credentials.NewStaticCredentials(accessKey, secretKey, ""),
 	})
 	if err != nil {
-		return err
+		l.Error(err)
+		return errors.New("could not initialize S3 session")
 	}
 
 	// Create a new S3 client with the session
@@ -196,7 +197,7 @@ func s3Access(l *zap.SugaredLogger, endpoint *string, accessKey, secretKey, buck
 	})
 	if err != nil {
 		l.Error(err)
-		return errors.Join(errUserFacingMsg, errors.New("could not issue head request to S3 bucket"))
+		return errors.New("could not issue head request to S3 bucket")
 	}
 
 	testKey := "everest-write-test"
@@ -207,7 +208,7 @@ func s3Access(l *zap.SugaredLogger, endpoint *string, accessKey, secretKey, buck
 	})
 	if err != nil {
 		l.Error(err)
-		return errors.Join(errUserFacingMsg, errors.New("could not write to S3 bucket"))
+		return errors.New("could not write to S3 bucket")
 	}
 
 	_, err = svc.GetObject(&s3.GetObjectInput{
@@ -216,7 +217,7 @@ func s3Access(l *zap.SugaredLogger, endpoint *string, accessKey, secretKey, buck
 	})
 	if err != nil {
 		l.Error(err)
-		return errors.Join(errUserFacingMsg, errors.New("could not read from S3 bucket"))
+		return errors.New("could not read from S3 bucket")
 	}
 
 	_, err = svc.DeleteObject(&s3.DeleteObjectInput{
@@ -225,7 +226,7 @@ func s3Access(l *zap.SugaredLogger, endpoint *string, accessKey, secretKey, buck
 	})
 	if err != nil {
 		l.Error(err)
-		return errors.Join(errUserFacingMsg, errors.New("could not delete an object from S3 bucket"))
+		return errors.New("could not delete an object from S3 bucket")
 	}
 
 	return nil
@@ -266,12 +267,8 @@ func validateCreateBackupStorageRequest(ctx echo.Context, l *zap.SugaredLogger)
 
 	// check data access
 	if err := validateStorageAccessByCreate(params, l); err != nil {
-		if errors.Is(err, errUserFacingMsg) {
-			return nil, errors.Join(err, errors.New("could not connect to the backup storage, please check the new credentials are correct"))
-		}
-
 		l.Error(err)
-		return nil, errors.New("could not connect to the backup storage, please check the new credentials are correct")
+		return nil, err
 	}
 
 	return &params, nil