Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

EVEREST-757 Implement namespaces endpoint and change dbengines to namespaced #392

Merged
merged 9 commits into from
Jan 29, 2024

Conversation

recharte
Copy link
Collaborator

@recharte recharte commented Jan 15, 2024

EVEREST-757 Powered by Pull Request Badge

EVEREST-757 Implement namespaces endpoint and change dbengines to namespaced

NOTE FOR REVIEWERS: Still missing api-tests, there are other dependencies (e.g. monitoring part) that need to be sorted out. I'll submit a follow-up PR to address the integration tests once the dependencies are sorted out.

Problem:
EVEREST-757

In order to serve the namespaces settings screen we need to provide a list of namespaces as well as the list of installed db engines per namespace.

Solution:
Fetch the list of namespaces from the configuration config map.
Namespace the dbengines endpoint.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

@recharte recharte requested a review from a user January 15, 2024 22:20
Copy link
Contributor

@oksana-grishchenko oksana-grishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few questions for better understanding of the problem.

api/proxy.go Show resolved Hide resolved
pkg/kubernetes/kubernetes.go Outdated Show resolved Hide resolved
docs/spec/openapi.yml Show resolved Hide resolved
Since this information forceably exists in the deployment spec, there's
no need to introduce an extra resource for this.
@recharte recharte changed the base branch from main to EVEREST-495-multi-namespaces January 16, 2024 17:36
api/everest_test.go Show resolved Hide resolved
@recharte recharte merged commit ed59734 into EVEREST-495-multi-namespaces Jan 29, 2024
3 of 4 checks passed
@recharte recharte deleted the EVEREST-757-multi-namespaces branch January 29, 2024 09:14
@recharte recharte mentioned this pull request Feb 7, 2024
3 tasks
recharte added a commit that referenced this pull request Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants