This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
EVEREST-757 Implement namespaces endpoint and change dbengines to namespaced #392
Merged
recharte
merged 9 commits into
EVEREST-495-multi-namespaces
from
EVEREST-757-multi-namespaces
Jan 29, 2024
Merged
EVEREST-757 Implement namespaces endpoint and change dbengines to namespaced #392
recharte
merged 9 commits into
EVEREST-495-multi-namespaces
from
EVEREST-757-multi-namespaces
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few questions for better understanding of the problem.
oksana-grishchenko
approved these changes
Jan 16, 2024
Since this information forceably exists in the deployment spec, there's no need to introduce an extra resource for this.
oksana-grishchenko
approved these changes
Jan 17, 2024
ghost
approved these changes
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVEREST-757 Implement namespaces endpoint and change dbengines to namespaced
NOTE FOR REVIEWERS: Still missing api-tests, there are other dependencies (e.g. monitoring part) that need to be sorted out. I'll submit a follow-up PR to address the integration tests once the dependencies are sorted out.
Problem:
EVEREST-757
In order to serve the namespaces settings screen we need to provide a list of namespaces as well as the list of installed db engines per namespace.
Solution:
Fetch the list of namespaces from the configuration config map.
Namespace the dbengines endpoint.
CHECKLIST
Jira
Tests