Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

EVEREST-496 Add multi namespaces monitoring #426

Merged
merged 11 commits into from
Feb 7, 2024
Merged

EVEREST-496 Add multi namespaces monitoring #426

merged 11 commits into from
Feb 7, 2024

Conversation

recharte
Copy link
Collaborator

@recharte recharte commented Feb 6, 2024 •
edited by jira bot
Loading

EVEREST-496 Powered by Pull Request Badge

Add multi namespaces monitoring

NOTE FOR REVIEWERS: Still missing api-tests, I'll submit a follow-up PR to address the integration tests once the dependencies are sorted out.
Problem:
EVEREST-496

Related pull requests

With the changes introduced in percona/everest-operator#265 we no longer need the /cluster-monitoring endpoint so it got removed.
Also now we manage the monitoring configs from the monitoring namespace and we include the targetNamespaces field in all monitoring config requests.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

recharte added 11 commits February 6, 2024 15:01
@recharte
EVEREST-496: add TargetNamespaces to GET monitoring-instances
ef7a89a
@recharte
EVEREST-496: add TargetNamespaces to POST monitoring-instances
f488558
@recharte
EVEREST-496: add TargetNamespaces to PATCH monitoring-instances
1b691a9
@recharte
EVEREST-496 autogen API code
1a2d214
@recharte
EVEREST-496 allow managing everest CRs in any namespace
fd06eb1
@recharte
EVEREST-496 add username to monitoring secret
97e7a8b
@recharte
EVEREST-496 prepare secrets management for multi-namespaces
8dbe470
@recharte
EVEREST-496 use monitoring resources from the monitoring namespace
c7ab016
@recharte
EVEREST-496 remove check for VMAgent use of monitoring config
f46cd6f 
With the introduction of VMAgent CR reconciliation in everest-operator
we no longer need to block the deletion of MonitoringConfigs if VMAgent
is using them.
@recharte
EVEREST-496 remove cluster-monitoring endpoint
c07fe41 
With the introduction of VMAgent reconciliation in the everest-operator
we no longer need an endpoint to create its spec.
@recharte
EVEREST-496 autogen API code
0fafd96
@recharte recharte marked this pull request as ready for review February 6, 2024 15:11
@recharte recharte requested a review from a user February 6, 2024 15:11
ghost
ghost approved these changes Feb 6, 2024
View reviewed changes
api/database_cluster.go Show resolved Hide resolved
oksana-grishchenko
oksana-grishchenko approved these changes Feb 7, 2024
View reviewed changes
api/monitoring_instance.go Show resolved Hide resolved
pkg/kubernetes/monitoring_config.go Show resolved Hide resolved
@recharte recharte merged commit 3603057 into EVEREST-495-multi-namespaces Feb 7, 2024
5 of 6 checks passed
@recharte recharte deleted the EVEREST-496-multi-namespaces-monitoring branch February 7, 2024 16:29
@recharte recharte mentioned this pull request Feb 7, 2024
Merged
3 tasks
recharte added a commit that referenced this pull request Feb 7, 2024
@recharte
EVEREST-496 Add multi namespaces monitoring (#426)
c07439a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oksana-grishchenko oksana-grishchenko oksana-grishchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@recharte @oksana-grishchenko