This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
EVEREST-386: backup name is required #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
gen1us2k,
recharte and
oksana-grishchenko
as code owners
gen1us2k
reviewed
Sep 12, 2023
recharte
reviewed
Sep 12, 2023
I personally don't think this is worth adding an integration test for. |
ghost
enabled auto-merge (squash)
How can we ensure that it works? I think that adding backups should be stable and covered by integration tests so we will be sure during the time that it's covered and it works so we do not need to spend time to re-test it during the release |
Tests added. |
gen1us2k
approved these changes
Sep 12, 2023
oksana-grishchenko
approved these changes
Sep 13, 2023
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVEREST-386