Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

EVEREST-203 Do not run registration for already registered k8s clusters #151

Merged
merged 8 commits into from
Sep 26, 2023

Conversation

gen1us2k
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #151 (bbb9ae1) into main (7baf844) will decrease coverage by 0.03%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #151      +/-   ##
========================================
- Coverage   5.12%   5.10%   -0.03%     
========================================
  Files         12      12              
  Lines       2788    2802      +14     
========================================
  Hits         143     143              
- Misses      2621    2635      +14     
  Partials      24      24              
Files Changed Coverage Δ
pkg/install/operators.go 4.71% <0.00%> (-0.10%) ⬇️
...kg/kubernetes/client/mock_kube_client_connector.go 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gen1us2k gen1us2k marked this pull request as ready for review September 25, 2023 14:06
@gen1us2k gen1us2k requested a review from recharte as a code owner September 25, 2023 14:06
@gen1us2k gen1us2k requested review from a user and oksana-grishchenko September 25, 2023 14:06
Copy link
Contributor

@oksana-grishchenko oksana-grishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, such an error would be definitely more user-friendly for the cli user and would cause less confusion. Not sure if it's gonna fix all of the problems required by the ticket, but I'm ok with merging this part.

pkg/install/operators.go Show resolved Hide resolved
pkg/install/operators.go Outdated Show resolved Hide resolved
Co-authored-by: Michal Kralik <[email protected]>
@gen1us2k gen1us2k requested a review from a user September 26, 2023 08:23
@gen1us2k gen1us2k enabled auto-merge (squash) September 26, 2023 08:57
Copy link
Collaborator

@recharte recharte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, I just didn't approve it yet to avoid triggering the auto-merge until you resolve the on-going conversation.

@gen1us2k gen1us2k requested a review from recharte September 26, 2023 11:55
@gen1us2k gen1us2k merged commit cf82255 into main Sep 26, 2023
8 checks passed
@gen1us2k gen1us2k deleted the EVEREST-203 branch September 26, 2023 11:56
gen1us2k added a commit that referenced this pull request Sep 28, 2023
…rs (#151)

* EVEREST-203 Do not run registration for already registered k8s clusters

* EVEREST-203 Generated files

* EVEREST-203 Added integration test

* EVEREST-203 Fixed test

* EVEREST-203 fixed test

* EVEREST-203 Better deletion handling

* EVEREST-203 Shut up linter

* Update pkg/install/operators.go

Co-authored-by: Michal Kralik <[email protected]>

---------

Co-authored-by: Michal Kralik <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants