-
Notifications
You must be signed in to change notification settings - Fork 5
EVEREST-203 Do not run registration for already registered k8s clusters #151
Conversation
Codecov Report
@@ Coverage Diff @@
## main #151 +/- ##
========================================
- Coverage 5.12% 5.10% -0.03%
========================================
Files 12 12
Lines 2788 2802 +14
========================================
Hits 143 143
- Misses 2621 2635 +14
Partials 24 24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, such an error would be definitely more user-friendly for the cli user and would cause less confusion. Not sure if it's gonna fix all of the problems required by the ticket, but I'm ok with merging this part.
Co-authored-by: Michal Kralik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, I just didn't approve it yet to avoid triggering the auto-merge until you resolve the on-going conversation.
…rs (#151) * EVEREST-203 Do not run registration for already registered k8s clusters * EVEREST-203 Generated files * EVEREST-203 Added integration test * EVEREST-203 Fixed test * EVEREST-203 fixed test * EVEREST-203 Better deletion handling * EVEREST-203 Shut up linter * Update pkg/install/operators.go Co-authored-by: Michal Kralik <[email protected]> --------- Co-authored-by: Michal Kralik <[email protected]>
No description provided.