This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
EVEREST-488 Merged tags into main branch #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs (#151) * EVEREST-203 Do not run registration for already registered k8s clusters * EVEREST-203 Generated files * EVEREST-203 Added integration test * EVEREST-203 Fixed test * EVEREST-203 fixed test * EVEREST-203 Better deletion handling * EVEREST-203 Shut up linter * Update pkg/install/operators.go Co-authored-by: Michal Kralik <[email protected]> --------- Co-authored-by: Michal Kralik <[email protected]>
recharte
reviewed
Oct 4, 2023
| @@ -9,7 +9,7 @@ spec: | |||
| sourceType: grpc | |||
| grpcPodConfig: | |||
| securityContextConfig: restricted | |||
| image: docker.io/percona/everest-catalog:latest | |||
| image: docker.io/percona/everest-catalog:0.3.0 | |||
There was a problem hiding this comment.
Shouldn't the main branch use the latest catalog tag? Why are we changing it to 0.3.0?
There was a problem hiding this comment.
I agree we should keep the latest tag in main
There was a problem hiding this comment.
I'm still playing around with tags.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
EVEREST-488
Short explanation of the problem.
The output of the
was empty because we do not merge tags into the main branch
Related pull requests
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Tests