Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

EVEREST-358 Disable list commands #165

Merged
merged 5 commits into from
Oct 9, 2023
Merged

EVEREST-358 Disable list commands #165

merged 5 commits into from
Oct 9, 2023

Conversation

gen1us2k
Copy link
Contributor

@gen1us2k gen1us2k commented Oct 6, 2023

CHANGE DESCRIPTION

Problem:
EVEREST-358

Short explanation of the problem.
The main goal from the product standpoint for the CLI is the provisioning/unprovisioning of Everest.
Currently, there's no way of getting kubernetes-id using CLI because the end user needs to call http://everest-backend:8080/v1/kubernetes to get it. Also, @recharte wanted to discuss the UX of the CLI at the nearest triad weekly and I assume we will revisit the list command.

Right now, the list command returns only versions and database engines which IMO does not provide any value for the user in comparison to the UI.

Another point is that to fix it completely we need to add filtration by cluster name for the list kubernetes endpoint to provide the end user the ability to use cluster name as an identifier to list different resources

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

@gen1us2k gen1us2k marked this pull request as ready for review October 6, 2023 13:15
@gen1us2k gen1us2k requested a review from a user October 6, 2023 13:15
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Merging #165 (ccb35b2) into main (fee271e) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #165   +/-   ##
=====================================
  Coverage   4.93%   4.93%           
=====================================
  Files         12      12           
  Lines       2899    2899           
=====================================
  Hits         143     143           
  Misses      2732    2732           
  Partials      24      24           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

commands/root.go Outdated Show resolved Hide resolved
Copy link
Contributor

@oksana-grishchenko oksana-grishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please elaborate more why it was decided to disable it but not fix it?

@gen1us2k
Copy link
Contributor Author

gen1us2k commented Oct 9, 2023

@oksana-grishchenko The main goal from the product standpoint for the CLI is the provisioning/unprovisioning of Everest.
Currently, there's no way of getting kubernetes-id using CLI because the end user needs to call http://everest-backend:8080/v1/kubernetes to get it. Also, @recharte wanted to discuss the UX of the CLI at the nearest triad weekly and I assume we will revisit the list command.

Right now, the list command returns only versions and database engines which IMO does not provide any value for the user in comparison to the UI.

Another point that to fix it completely we need to add filtration by cluster name for list kubernetes endpoint to provide the end user an ability to use cluster name as an identifier to list different resources

@gen1us2k gen1us2k changed the title EVEREST-358 Disable list commands for now EVEREST-358 Disable list commands Oct 9, 2023
@gen1us2k gen1us2k merged commit dbb32e2 into main Oct 9, 2023
8 checks passed
@gen1us2k gen1us2k deleted the EVEREST-358 branch October 9, 2023 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants