This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
EVEREST-855 Fix namespaces validation #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recharte
approved these changes
Feb 15, 2024
oksana-grishchenko
added a commit
that referenced
this pull request
Feb 15, 2024
(cherry picked from commit 28304c2)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix namespaces validation
Problem:
EVEREST-855
Wizard allowed an empty namespace
Cause:
Missed cornercase:
strings.Splitapplied to an empty string returns a slice of length 1 (with an empty string as the first element), which from the implementation perspective was considered as a defined namespace.CHECKLIST
Jira
Tests