Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replaced pxc-operator service name hardcode #381

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

71g3pf4c3
Copy link

Related to #380
Fixed service name in metadata and labels

@it-percona-cla
Copy link

it-percona-cla commented Sep 20, 2024

CLA assistant check
All committers have signed the CLA.

@71g3pf4c3 71g3pf4c3 force-pushed the fix-pxc-operator-service-name-hardcode branch from 8e6930c to a6c73b4 Compare September 20, 2024 16:01
@jvpasinatto
Copy link
Contributor

Thank you for the contribution! Please bump the chart version.

@71g3pf4c3
Copy link
Author

Thank you for the contribution! Please bump the chart version.

Bumped version, happy to help!

@71g3pf4c3
Copy link
Author

@jvpasinatto please consider merging. This bug potentially can break installations

@jvpasinatto
Copy link
Contributor

Hi @71g3pf4c3, sorry for the delay. I discussed this with my colleagues, and it seems pxc-operator will create a service with name "percona-xtradb-cluster-operator" either way, so with your PR we end up with 2 services. So, if you want to be able to specify the service name we need to change operator code. Could you please create a ticket for this functionality if thats what you desire here https://perconadev.atlassian.net/jira/software/c/projects/K8SPXC/boards/63?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants