K8SPG-594 delete custom extensions from installed #967
+101
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inelpandzic
requested changes
Dec 4, 2024
| @@ -42,3 +47,28 @@ func Uninstall(archivePath string) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func DisableCustomExtensionsInPostgreSQL(ctx context.Context, customExtensionsForDeletion []string, exec postgres.Executor) error { | |||
There was a problem hiding this comment.
I would name it simply like DropExtension.
There was a problem hiding this comment.
@inelpandzic We have similar method for pgaudit and I decided to keep the same name for consistency. What do you think?
But I agree that the name you suggested is easier.
| @@ -535,6 +539,47 @@ func (r *PGClusterReconciler) reconcileCustomExtensions(cr *v2.PerconaPGCluster) | |||
| extensionKeys = append(extensionKeys, key) | |||
| } | |||
|
|
|||
| if cr.CompareVersion("2.6.0") >= 0 { | |||
There was a problem hiding this comment.
I would put all this block in the extensions package (in the k8s.go file) we have and here you just call some function, like extension.Remove or something.
…ercona-postgresql-operator into K8SPG-594_delete_installed_ext
commit: 4c6bf22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
We need to delete custom extensions not only from available but from installed too. If we deleted a custom extension from available extensions it doesn't work correctly so anyway we should delete it.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
As solution, custom annotations with the list of installed custom extensions were added.
Under each reconciliation extension either added to annotations (if it's new one and were deleted in custom extensions in CR or if it was deleted from custom extensions we should delete in from DB and from annotations too )
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability