Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPSMDB-850 - Server Side Encryption Support #1198

Merged
merged 14 commits into from
Sep 19, 2023
Merged

Conversation

mertgonul
Copy link
Contributor

@mertgonul mertgonul commented Mar 27, 2023

K8SPSMDB-850 Powered by Pull Request Badge

SSE and SSE-C Support

Problem:
Percona Backup for MongoDB supports Server Side Encryption (SSE and SSE-C)

Jira Ref: https://jira.percona.com/browse/K8SPSMDB-850

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/M 30-99 lines label Mar 27, 2023
@CLAassistant
Copy link

CLAassistant commented Mar 27, 2023

CLA assistant check
All committers have signed the CLA.

@hors hors requested a review from spron-in May 5, 2023 16:27
deploy/crd.yaml Outdated
Comment on lines 115 to 125
serverSideEncryption:
properties:
sseAlgorithm:
type: string
kmsKeyID:
type: string
sseCustomerAlgorithm:
type: string
sseCustomerKey:
type: string
type: object
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mertgonul Could you please add this new section to https://github.com/percona/percona-server-mongodb-operator/blob/main/deploy/cr.yaml . Also, please check https://github.com/percona/percona-server-mongodb-operator/blob/main/Makefile to understand the correct way of adding new fields to all needed CRDs.

@egegunes
Copy link
Contributor

@mertgonul please run gofmt on all files

@egegunes
Copy link
Contributor

egegunes commented Sep 6, 2023

@mertgonul we want to include this in upcoming release, I'll take over.

@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/M 30-99 lines labels Sep 18, 2023
Copy link
Contributor

@egegunes egegunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pooknull please update deploy/backup/backup.yaml and deploy/backup/restore.yaml

@pooknull pooknull requested review from egegunes and hors September 19, 2023 07:25
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-eks-credentials passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
pitr-physical passed
recover-no-primary passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded passed
upgrade-sharded passed
users passed
version-service passed
We run 45 out of 45

commit: 60ffce6
image: perconalab/percona-server-mongodb-operator:PR-1198-60ffce67

@hors hors merged commit 3c58298 into percona:main Sep 19, 2023
8 checks passed
@hors
Copy link
Collaborator

hors commented Sep 19, 2023

@mertgonul thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community size/L 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants