K8SPSMDB-1183 bundle generations for psmdb #1681
Conversation
nmarukovich
requested review from
tplavcic,
ptankov,
jvpasinatto,
eleo007,
hors,
egegunes,
inelpandzic and
pooknull
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| bundle.annotations.yaml >"${bundle_directory}/metadata/annotations.yaml" | ||
|
|
||
| # certified-operators | ||
| elif [ ${DISTRIBUTION} == 'redhat' ]; then |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
| elif [ ${DISTRIBUTION} == 'redhat' ]; then | |
| elif [ "${DISTRIBUTION}" == 'redhat' ]; then |
commit: ce0549c |
|
|
||
| KUSTOMIZE = $(REPO_ROOT)/bin/kustomize | ||
| kustomize: ## Download kustomize locally if necessary. | ||
| $(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/kustomize/[email protected]) |
There was a problem hiding this comment.
can we update this? I see in github there is v5.5.0 version
There was a problem hiding this comment.
we use this version for all our operators in all our makefile. I can check can we update it or not)
| tools: tools/$(SYSTEM)/kubectl | ||
| tools/$(SYSTEM)/kubectl: | ||
| install -d '$(dir $@)' | ||
| curl -fSL -o '$@' 'https://dl.k8s.io/release/$(shell curl -Ls https://dl.k8s.io/release/stable-1.21.txt)/bin/$(OS_KERNEL)/$(OS_MACHINE)/kubectl' |
There was a problem hiding this comment.
can we update this? stable-1.21
There was a problem hiding this comment.
which one do you want to use?
| tools: tools/$(SYSTEM)/operator-sdk | ||
| tools/$(SYSTEM)/operator-sdk: | ||
| install -d '$(dir $@)' | ||
| curl -fSL -o '$@' 'https://github.com/operator-framework/operator-sdk/releases/download/v1.19.1/operator-sdk_$(OS_KERNEL)_$(OS_MACHINE)' |
| tools: tools/$(SYSTEM)/opm | ||
| tools/$(SYSTEM)/opm: | ||
| install -d '$(dir $@)' | ||
| curl -fSL -o '$@' 'https://github.com/operator-framework/operator-registry/releases/download/v1.33.0/$(OS_KERNEL)-$(OS_MACHINE)-opm' |
There was a problem hiding this comment.
can we update this? Also, shoud this be aligned with the version from operator-sdk?
| endif | ||
|
|
||
| KUSTOMIZE = $(REPO_ROOT)/bin/kustomize | ||
| kustomize: ## Download kustomize locally if necessary. |
There was a problem hiding this comment.
This does not work for me, when I execute make bundles I get an error in this line:
/bin/bash: ..repos/percona-server-mongodb-operator/bin/kustomize: No such file or directory
Yes, I don't have kustomize in bin/ folder, but this go-get-tool should be able to download it
There was a problem hiding this comment.
I see, I will check it too. And I agree that go-get-tool should download it.
| @@ -0,0 +1,6 @@ | |||
| 1. Set VERSION env variable | |||
There was a problem hiding this comment.
Operator version in format "1.18.0" ?
| @@ -0,0 +1,6 @@ | |||
| 1. Set VERSION env variable | |||
| 2. Update rbac and operator in config | |||
| @@ -0,0 +1,6 @@ | |||
| 1. Set VERSION env variable | |||
| 2. Update rbac and operator in config | |||
| 2. Choose the mode (cluster or namespace) and update bundle/kustomization.yaml and makefile with necessary mode. | |||
There was a problem hiding this comment.
why we need to update in two places?
|
also please add a PR description, it'd be great if you put some usage example |
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability