K8SPSMDB-1249: Fix smart update for pods that are not member of replset #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egegunes
requested review from
nmarukovich,
ptankov,
jvpasinatto,
eleo007,
hors,
inelpandzic and
pooknull
as code owners
gkech
reviewed
Jan 10, 2025
| membersLive := 0 | ||
| for _, member := range rsMembers { | ||
| switch member.State { | ||
| case mongo.MemberStatePrimary, mongo.MemberStateSecondary, mongo.MemberStateArbiter: |
There was a problem hiding this comment.
minor: Here we can also include the default case with a continue action.
There was a problem hiding this comment.
is there any practical difference?
There was a problem hiding this comment.
Only for better readability and clarity since unhandled cases are explicitly handled in a way (through the default). The behaviour remains the same!
Comment on lines
525
to
528
| podName, ok := tags["podName"] | ||
| if !ok { | ||
| continue | ||
| } |
There was a problem hiding this comment.
We can write this in a more compact way if we want given that podName is not used further, like this:
if podName, ok := tags["podName"]; ok {
rsMembers[podName] = api.ReplsetMemberStatus{
Name: member.Name,
State: member.State,
StateStr: member.StateStr,
}
}
it is also more consistent with the style we are using in the same function.
gkech
previously approved these changes
Jan 13, 2025
pooknull
previously approved these changes
Jan 13, 2025
gkech
previously approved these changes
Jan 13, 2025
hors
previously approved these changes
Jan 13, 2025
nmarukovich
reviewed
Jan 14, 2025
commit: 19b115d |
hors
approved these changes
Jan 14, 2025
gkech
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Operator can not finish smart update if update is triggered before replset is initialized.
Steps to reproduce:
cluster1-cfg-0and creates users there. As of now, replset has only one member:cluster1-cfg-0.cluster1-cfg-2.cluster1-cfg-2is not added to replset yet.Solution:
Maintain a map of members in cluster status and check if pod is a member of replset using this map. If pod is not a member, operator doesn't need to check if pod is primary and just update it.
Warning
Arbiter members won't show up in members map in status. It's because we use pod names as keys to map and we get this information from member tags in replset configuration but arbiters are not allowed to have tags.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability