Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPS-417: Enable PROXY protocol #523

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

K8SPS-417: Enable PROXY protocol #523

wants to merge 4 commits into from

Conversation

egegunes
Copy link
Contributor

@egegunes egegunes commented Jan 17, 2024

K8SPS-417 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
Short explanation of the problem.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/S 10-29 lines label Jan 17, 2024
@pull-request-size pull-request-size bot added size/M 30-99 lines and removed size/S 10-29 lines labels Feb 2, 2024
@@ -153,6 +153,7 @@ create_default_cnf() {
echo '[mysqld]' >$CFG
sed -i "/\[mysqld\]/a read_only=ON" $CFG
sed -i "/\[mysqld\]/a server_id=${SERVER_ID}" $CFG
sed -i "/\[mysqld\]/a bind_address=${POD_IP}" $CFG
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hors @Tusamarco is there any danger of setting bind_address to pod's IP?

@egegunes egegunes marked this pull request as ready for review February 5, 2024 13:31
@JNKPercona
Copy link
Collaborator

Test name Status
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
service-per-pod passed
sidecars passed
smart-update passed
tls-cert-manager passed
users passed
version-service passed
We run 30 out of 30

commit: f00253e
image: perconalab/percona-server-mysql-operator:PR-523-f00253e

@hors hors marked this pull request as draft April 8, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M 30-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants