K8SPXC-926: increase MaxConcurrentReconciles
#1131
Draft
+1,216
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
size/XS
egegunes
reviewed
Apr 20, 2022
pkg/controller/pxc/controller.go
Outdated
| @@ -115,7 +137,7 @@ type ReconcilePerconaXtraDBCluster struct { | |||
| } | |||
|
|
|||
| func (r *ReconcilePerconaXtraDBCluster) logger(name, namespace string) logr.Logger { | |||
| return log.NewDelegatingLogger(r.log).WithName("perconaxtradbcluster"). | |||
| return r.log.WithName("perconaxtradbcluster"). | |||
There was a problem hiding this comment.
what was the reason behind these changes?
https://jira.percona.com/browse/K8SPXC-926 If we use an operator for two or more clusters, and one of them is stuck, we can't update the other clusters. That's why we need concurrent reconciles
pooknull
force-pushed
the
dev/K8SPXC-926-concurrent-reconciles
branch
from
685eb60
to
d64e70d
Compare
commit: d64e70d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/K8SPXC-926
If we use an operator for two or more clusters, and one of them is stuck, we can't update the other clusters. That's why we need concurrent reconciles