-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPXC-1301: Run operator locally #1522
Open
inelpandzic
wants to merge
37
commits into
main
Choose a base branch
from
k8spxc-1301-run-operator-locally
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+632
−634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inelpandzic
requested review from
hors,
egegunes and
pooknull
as code owners
November 24, 2023 14:20
egegunes
previously approved these changes
Dec 11, 2023
@inelpandzic please fix conflicts and check tests |
commit: 1ed4605 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
The operator should be able to run on a local machine against a deployed K8S cluster.
The solution introduces two env vars:
OPERATOR_NAMESPACE
- namespace in which the operator is running. If not present, the operator will read it from/var/run/secrets/kubernetes.io/serviceaccount/namespace
DISABLE_WEBHOOK
- used only when the operator runs locally. This is needed since in order to set up the webhook we need the operator deployment object, but since we are running locally, that is not available.This PR also fixes #1511
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability