-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPXC-1462: Restart PXC pods after monitor user password change #1816
base: main
Are you sure you want to change the base?
Conversation
aac4964
to
4b2d736
Compare
4b2d736
to
a8caddb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not like this idea. We should not have unneeded restarts. Maybe we can restart it if custom sidecar is used but up to @egegunes
I use envFromSecret:
|
I understand the desire to minimize the number of restarts, but also want to be sure that we are not overcomplicating it here. Am I looking at it wrong? |
e4302ac
to
94bee94
Compare
94bee94
to
0b9e1de
Compare
@spron-in i really don't want to restart PXC pods blindly. we can always say user should restart pods themselves but if we want to do it in automatic way, i believe current changes look good. |
0b9e1de
to
7932056
Compare
@inelpandzic please review |
commit: 0a78eaf |
Problem:
monitor
user could be used not only in pmm sidecar containers, but in custom mysqld-exporter sidecar container running near pxc. If these custom sidecars are usingmonitor
user, they need a pod restart after password change, same as pmm sidecars.Cause:
monitor
user password update causes pxc pods restart only when pmm is enabledSolution:
Restart PXC pods without checking if a PMM is enabled.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability