K8SPXC-1411: allow to enable/disable TLS in a running cluster #1844
+642
−396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
changed the title
pooknull
requested review from
tplavcic,
nmarukovich,
ptankov,
jvpasinatto,
eleo007,
hors,
egegunes and
inelpandzic
as code owners
egegunes
requested changes
Oct 21, 2024
pkg/controller/pxc/tls.go
Outdated
| return nil | ||
| } | ||
|
|
||
| annotationTLSState, ok := cr.Annotations[naming.AnnotationTLS] |
There was a problem hiding this comment.
I would do this with a status field or with status.conditions rather than with an annotation
pkg/controller/pxc/tls.go
Outdated
Comment on lines
356
to
358
| crOrig := cr.DeepCopy() | ||
| cr.Spec.Unsafe.TLS = !*cr.Spec.TLS.Enabled | ||
| if cr.Spec.Unsafe.TLS != crOrig.Spec.Unsafe.TLS { |
There was a problem hiding this comment.
if TLS is disabled without enabling the unsafe flag we'll return an error before (in CheckNSetDefaults) and won't enter this function. so I'm not sure if we need to do this check
inelpandzic
previously approved these changes
Oct 29, 2024
hors
previously approved these changes
Nov 8, 2024
inelpandzic
previously approved these changes
Nov 18, 2024
egegunes
previously approved these changes
Nov 20, 2024
inelpandzic
previously approved these changes
Nov 21, 2024
pull-request-size
bot
added
size/XXL
inelpandzic
approved these changes
Dec 4, 2024
hors
approved these changes
Dec 4, 2024
egegunes
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPXC-1411
DESCRIPTION
This PR allows operator to enable/disable TLS in a running cluster by automating the following tasks:
when
.spec.tls.enabledis switched tofalse:.spec.pausetotruespec.unsafeFlags.tlstotrue.spec.pausetofalsewhen
.spec.tls.enabledis switched totrue:.spec.pausetotruespec.unsafeFlags.tlstofalse.spec.pausetofalseA
tlscondition has also been added to a cluster. It will show the state of.spec.tls.enabledfield before it was switched. The values of this condition areenabledanddisabledvalues. After all automated tasks have been completed, it will be updated with the actual state of.spec.tls.enabled.Note to developers: the
deploymethod contained a lot of duplicated code from theupdatePodmethod. In this PR I decided to minimize it by using theupdatePodinside.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability