-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GITHUB-ISSUE-1847: Fix Azure binlog upload for large files #1848
base: main
Are you sure you want to change the base?
GITHUB-ISSUE-1847: Fix Azure binlog upload for large files #1848
Conversation
@dcaputo-harmoni tests are failing because GKE 1.27 is removed. I'll ping you to ask rebase after #1849 merged. |
@egegunes No problem, just let me know when |
_, err := a.client.UploadStream(ctx, a.container, objPath, data, nil) | ||
uploadOption := azblob.UploadStreamOptions{ | ||
Concurrency: 4, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcaputo-harmoni Hi! Thank you for your contribution.
Is it possible to make this value configurable? I believe it will super useful for all our users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible, just don't have the bandwidth to do it at the moment. Given that it's currently broken for large files what I would suggest is that we release as is to fix the issue and then just open a feature request / issue to track it and I'll get that in down the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, time is always the problem.
We can take over this PR and make value configurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make concurrency value configurable.
@nmarukovich please create a jira ticket and let's take over this PR. |
commit: fb6dd1c |
Fixes #1847