Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPXC-1510 Enable log_error_suppression_list to reduce spam in MySQL error log #1876

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelcoburn
Copy link

@michaelcoburn michaelcoburn commented Nov 21, 2024

K8SPXC-1510 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
MySQL Error Log writes a Warning when a deprecated feature is used. This spams the logs and makes them harder to read.
{"log":"2024-11-21T16:06:34.591561Z 151230 [Warning] [MY-013360] [Server] Plugin mysql_native_password reported: ''mysql_native_password' is deprecated and will be removed in a future release. Please use caching_sha2_password instead'\n","file":"/var/lib/mysql/mysqld-error.log"}

Cause:
Users are created with mysql_native_password authentication and should be at some point migrated to caching_sha2_password

Solution:
I've added the example to cr.yaml and left it commented out.
Consider instead the PR is to enable mysqld configuration for at least this one feature so that default logs are less spammy.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PXC version?
  • Does the change support oldest and newest supported Kubernetes version?

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

@it-percona-cla
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@JNKPercona
Copy link
Collaborator

Test name Status
affinity-8-0 failure
auto-tuning-8-0 failure
cross-site-8-0 failure
demand-backup-cloud-8-0 failure
demand-backup-encrypted-with-tls-8-0 failure
demand-backup-8-0 failure
haproxy-5-7 failure
haproxy-8-0 failure
init-deploy-5-7 failure
init-deploy-8-0 skipped
limits-8-0 skipped
monitoring-2-0-8-0 skipped
one-pod-5-7 skipped
one-pod-8-0 skipped
pitr-8-0 skipped
pitr-gap-errors-8-0 skipped
proxy-protocol-8-0 skipped
proxysql-sidecar-res-limits-8-0 skipped
pvc-resize-5-7 skipped
pvc-resize-8-0 skipped
recreate-8-0 skipped
restore-to-encrypted-cluster-8-0 skipped
scaling-proxysql-8-0 skipped
scaling-8-0 skipped
scheduled-backup-5-7 skipped
scheduled-backup-8-0 skipped
security-context-8-0 skipped
smart-update1-8-0 skipped
smart-update2-8-0 skipped
storage-8-0 skipped
tls-issue-cert-manager-ref-8-0 skipped
tls-issue-cert-manager-8-0 skipped
tls-issue-self-8-0 skipped
upgrade-consistency-8-0 skipped
upgrade-haproxy-5-7 skipped
upgrade-haproxy-8-0 skipped
upgrade-proxysql-5-7 skipped
upgrade-proxysql-8-0 skipped
users-5-7 skipped
users-8-0 skipped
validation-hook-8-0 skipped
We run 9 out of 41

commit: b868183
image: perconalab/percona-xtradb-cluster-operator:PR-1876-b868183a

Copy link
Contributor

@egegunes egegunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @michaelcoburn. I aborted the e2e test suite, that's why they seem failed/skipped.

I think adding an example for this is good but I don't think we should suppress this warning by default as people might miss it until it's too late.

@egegunes egegunes added this to the v1.16.0 milestone Nov 22, 2024
@hors hors modified the milestones: v1.16.0, v1.17.0 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants