Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPXC-1410 add PXC 8.4.X support #1878

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

K8SPXC-1410 add PXC 8.4.X support #1878

wants to merge 8 commits into from

Conversation

hors
Copy link
Collaborator

@hors hors commented Nov 22, 2024

K8SPXC-1410 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
Short explanation of the problem.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PXC version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/L 100-499 lines label Nov 22, 2024
@hors hors marked this pull request as draft November 22, 2024 09:09
@egegunes egegunes added this to the v1.16.0 milestone Nov 22, 2024
@pull-request-size pull-request-size bot added size/XL 500-999 lines and removed size/L 100-499 lines labels Nov 22, 2024
@@ -69,7 +69,7 @@

CFG=/etc/mysql/node.cnf
MYSQL_VERSION=$(mysqld -V | awk '{print $3}' | awk -F'.' '{print $1"."$2}')
if [ "$MYSQL_VERSION" == '8.0' ]; then
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then
if [[ $MYSQL_VERSION =~ ^(8\.0|8\.4)$ ]]; then

@@ -165,7 +165,7 @@
sed -i "/\[mysqld\]/a early-plugin-load=keyring_vault.so" $CFG
sed -i "/\[mysqld\]/a keyring_vault_config=$vault_secret" $CFG

if [ "$MYSQL_VERSION" == '8.0' ]; then
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then
if [[ $MYSQL_VERSION =~ ^(8\.0|8\.4)$ ]]; then

@@ -293,14 +292,13 @@
echo "Cluster name is invalid, please check DNS"
exit 1
fi

if [[ -n ${NOTIFY_SOCKET} && ${MYSQL_VERSION} == '8.0' ]]; then
if [[ -n ${NOTIFY_SOCKET} && ${MYSQL_VERSION} =~ ^(8\.0|8\.4)$ ]]; then
nohup /var/lib/mysql/mysql-state-monitor >/var/lib/mysql/mysql-state-monitor.log 2>&1 < /dev/null &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
nohup /var/lib/mysql/mysql-state-monitor >/var/lib/mysql/mysql-state-monitor.log 2>&1 < /dev/null &
nohup /var/lib/mysql/mysql-state-monitor >/var/lib/mysql/mysql-state-monitor.log 2>&1 </dev/null &

@@ -385,15 +387,15 @@
file_env 'MONITOR_HOST' 'localhost'
file_env 'MONITOR_PASSWORD' 'monitor' 'monitor'
file_env 'REPLICATION_PASSWORD' 'replication' 'replication'
if [ "$MYSQL_VERSION" == '8.0' ]; then
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then
if [[ $MYSQL_VERSION =~ ^(8\.0|8\.4)$ ]]; then

fi
set -x

if [[ ${MYSQL_VERSION} == '8.0' ]]; then
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then
if [[ $MYSQL_VERSION =~ ^(8\.0|8\.4)$ ]]; then

Comment on lines 525 to 526
while [[ "${mysqlState}" != "ready" ]]; do
mysqlState=$(tr -d '\0' < ${MYSQL_STATE_FILE})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
while [[ "${mysqlState}" != "ready" ]]; do
mysqlState=$(tr -d '\0' < ${MYSQL_STATE_FILE})
while [[ ${mysqlState} != "ready" ]]; do
mysqlState=$(tr -d '\0' <${MYSQL_STATE_FILE})

@hors hors marked this pull request as ready for review November 25, 2024 17:32
@nmarukovich nmarukovich self-requested a review December 2, 2024 12:54
@JNKPercona
Copy link
Collaborator

Test name Status
affinity-8-0 passed
auto-tuning-8-0 passed
cross-site-8-0 passed
custom-users-8-0 passed
demand-backup-cloud-8-0 failure
demand-backup-encrypted-with-tls-8-0 passed
demand-backup-8-0 passed
haproxy-5-7 passed
haproxy-8-0 passed
init-deploy-5-7 passed
init-deploy-8-0 passed
limits-8-0 passed
monitoring-2-0-8-0 passed
one-pod-5-7 passed
one-pod-8-0 passed
pitr-8-0 passed
pitr-gap-errors-8-0 passed
proxy-protocol-8-0 passed
proxysql-sidecar-res-limits-8-0 passed
pvc-resize-5-7 passed
pvc-resize-8-0 passed
recreate-8-0 passed
restore-to-encrypted-cluster-8-0 passed
scaling-proxysql-8-0 passed
scaling-8-0 passed
scheduled-backup-5-7 passed
scheduled-backup-8-0 passed
security-context-8-0 passed
smart-update1-8-0 passed
smart-update2-8-0 passed
storage-8-0 passed
tls-issue-cert-manager-ref-8-0 passed
tls-issue-cert-manager-8-0 passed
tls-issue-self-8-0 passed
upgrade-consistency-8-0 failure
upgrade-haproxy-5-7 passed
upgrade-haproxy-8-0 passed
upgrade-proxysql-5-7 passed
upgrade-proxysql-8-0 passed
users-5-7 passed
users-8-0 passed
validation-hook-8-0 passed
We run 42 out of 42

commit: df55f48
image: perconalab/percona-xtradb-cluster-operator:PR-1878-df55f48d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL 500-999 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants