-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPXC-1410 add PXC 8.4.X support #1878
base: main
Are you sure you want to change the base?
Conversation
@@ -69,7 +69,7 @@ | |||
|
|||
CFG=/etc/mysql/node.cnf | |||
MYSQL_VERSION=$(mysqld -V | awk '{print $3}' | awk -F'.' '{print $1"."$2}') | |||
if [ "$MYSQL_VERSION" == '8.0' ]; then | |||
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then | |
if [[ $MYSQL_VERSION =~ ^(8\.0|8\.4)$ ]]; then |
@@ -165,7 +165,7 @@ | |||
sed -i "/\[mysqld\]/a early-plugin-load=keyring_vault.so" $CFG | |||
sed -i "/\[mysqld\]/a keyring_vault_config=$vault_secret" $CFG | |||
|
|||
if [ "$MYSQL_VERSION" == '8.0' ]; then | |||
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then | |
if [[ $MYSQL_VERSION =~ ^(8\.0|8\.4)$ ]]; then |
@@ -293,14 +292,13 @@ | |||
echo "Cluster name is invalid, please check DNS" | |||
exit 1 | |||
fi | |||
|
|||
if [[ -n ${NOTIFY_SOCKET} && ${MYSQL_VERSION} == '8.0' ]]; then | |||
if [[ -n ${NOTIFY_SOCKET} && ${MYSQL_VERSION} =~ ^(8\.0|8\.4)$ ]]; then | |||
nohup /var/lib/mysql/mysql-state-monitor >/var/lib/mysql/mysql-state-monitor.log 2>&1 < /dev/null & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
nohup /var/lib/mysql/mysql-state-monitor >/var/lib/mysql/mysql-state-monitor.log 2>&1 < /dev/null & | |
nohup /var/lib/mysql/mysql-state-monitor >/var/lib/mysql/mysql-state-monitor.log 2>&1 </dev/null & |
@@ -385,15 +387,15 @@ | |||
file_env 'MONITOR_HOST' 'localhost' | |||
file_env 'MONITOR_PASSWORD' 'monitor' 'monitor' | |||
file_env 'REPLICATION_PASSWORD' 'replication' 'replication' | |||
if [ "$MYSQL_VERSION" == '8.0' ]; then | |||
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then | |
if [[ $MYSQL_VERSION =~ ^(8\.0|8\.4)$ ]]; then |
fi | ||
set -x | ||
|
||
if [[ ${MYSQL_VERSION} == '8.0' ]]; then | ||
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
if [[ "$MYSQL_VERSION" =~ ^(8\.0|8\.4)$ ]]; then | |
if [[ $MYSQL_VERSION =~ ^(8\.0|8\.4)$ ]]; then |
while [[ "${mysqlState}" != "ready" ]]; do | ||
mysqlState=$(tr -d '\0' < ${MYSQL_STATE_FILE}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
while [[ "${mysqlState}" != "ready" ]]; do | |
mysqlState=$(tr -d '\0' < ${MYSQL_STATE_FILE}) | |
while [[ ${mysqlState} != "ready" ]]; do | |
mysqlState=$(tr -d '\0' <${MYSQL_STATE_FILE}) |
commit: df55f48 |
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability