-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPXC-377: Add VS support and bug fix #1882
base: main
Are you sure you want to change the base?
Conversation
@@ -141,3 +145,15 @@ after-release: manifests | |||
-e "/^ backup:/,/^ image:/{s#image: .*#image: perconalab/percona-xtradb-cluster-operator:main-pxc8.0-backup#}" \ | |||
-e "/initContainer:/,/image:/{s#image: .*#image: perconalab/percona-xtradb-cluster-operator:main#}" \ | |||
-e "/^ pmm:/,/^ image:/{s#image: .*#image: perconalab/pmm-client:dev-latest#}" deploy/cr.yaml | |||
|
|||
version-service-client: swagger | |||
curl https://raw.githubusercontent.com/Percona-Lab/percona-version-service/$(VS_BRANCH)/api/version.swagger.yaml \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we define the default VS_BRANCH
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, probably we should, main
?
--type=json \ | ||
-p='[{"op": "replace", "path": "/spec/users/1/passwordSecretRef", "value": null}]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
--type=json \ | |
-p='[{"op": "replace", "path": "/spec/users/1/passwordSecretRef", "value": null}]' | |
--type=json \ | |
-p='[{"op": "replace", "path": "/spec/users/1/passwordSecretRef", "value": null}]' |
CHANGE DESCRIPTION
Problem:
Start sending
UserManagementEnabled
to version-service.This PR fixes:
passwordSecretRef
is on a created userCHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability