K8SPXC-377: Add VS support and bug fix #1882
Open
+3,257
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inelpandzic
requested review from
hors,
egegunes and
pooknull
as code owners
pooknull
reviewed
Nov 27, 2024
| @@ -141,3 +145,15 @@ after-release: manifests | |||
| -e "/^ backup:/,/^ image:/{s#image: .*#image: perconalab/percona-xtradb-cluster-operator:main-pxc8.0-backup#}" \ | |||
| -e "/initContainer:/,/image:/{s#image: .*#image: perconalab/percona-xtradb-cluster-operator:main#}" \ | |||
| -e "/^ pmm:/,/^ image:/{s#image: .*#image: perconalab/pmm-client:dev-latest#}" deploy/cr.yaml | |||
|
|
|||
| version-service-client: swagger | |||
| curl https://raw.githubusercontent.com/Percona-Lab/percona-version-service/$(VS_BRANCH)/api/version.swagger.yaml \ | |||
There was a problem hiding this comment.
Should we define the default VS_BRANCH?
There was a problem hiding this comment.
Yeah, probably we should, main?
nmarukovich
previously approved these changes
Nov 28, 2024
inelpandzic
changed the title
inelpandzic
requested review from
tplavcic,
ptankov,
jvpasinatto and
eleo007
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+42
to
+43
| --type=json \ | ||
| -p='[{"op": "replace", "path": "/spec/users/1/passwordSecretRef", "value": null}]' |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| --type=json \ | |
| -p='[{"op": "replace", "path": "/spec/users/1/passwordSecretRef", "value": null}]' | |
| --type=json \ | |
| -p='[{"op": "replace", "path": "/spec/users/1/passwordSecretRef", "value": null}]' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Start sending
UserManagementEnabledto version-service.This PR fixes:
passwordSecretRefis on a created userCHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability