K8SPXC-1222: assign MYSQL_VERSION variable in liveness and readiness #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleo007
requested review from
hors,
egegunes,
inelpandzic and
pooknull
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -22,8 +22,9 @@ | |||
| #Timeout exists for instances where mysqld may be hung | |||
| TIMEOUT=$((${LIVENESS_CHECK_TIMEOUT:-5} - 1)) | |||
| MYSQL_STATE=ready | |||
| MYSQL_VERSION=$(mysqld -V | awk '{print $3}' | awk -F'.' '{print $1"."$2}') | |||
| if [[ ${MYSQL_VERSION} == '8.0' ]]; then | |||
| MYSQL_STATE=$(tr -d '\0' < ${MYSQL_STATE_FILE}) | |||
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| MYSQL_STATE=$(tr -d '\0' < ${MYSQL_STATE_FILE}) | |
| MYSQL_STATE=$(tr -d '\0' <${MYSQL_STATE_FILE}) |
| @@ -17,8 +17,9 @@ | |||
| AVAILABLE_WHEN_DONOR=${AVAILABLE_WHEN_DONOR:-1} | |||
| NODE_IP=$(hostname -I | awk ' { print $1 } ') | |||
| MYSQL_STATE=ready | |||
| MYSQL_VERSION=$(mysqld -V | awk '{print $3}' | awk -F'.' '{print $1"."$2}') | |||
| if [[ ${MYSQL_VERSION} == '8.0' ]]; then | |||
| MYSQL_STATE=$(tr -d '\0' < ${MYSQL_STATE_FILE}) | |||
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| MYSQL_STATE=$(tr -d '\0' < ${MYSQL_STATE_FILE}) | |
| MYSQL_STATE=$(tr -d '\0' <${MYSQL_STATE_FILE}) |
| if [[ -n ${NOTIFY_SOCKET} && ${MYSQL_VERSION} =~ ^(8\.0|8\.4)$ ]]; then | ||
| export NOTIFY_SOCKET=${MYSQL_NOTIFY_SOCKET} | ||
| nohup /var/lib/mysql/mysql-state-monitor >/var/lib/mysql/mysql-state-monitor.log 2>&1 < /dev/null & |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| nohup /var/lib/mysql/mysql-state-monitor >/var/lib/mysql/mysql-state-monitor.log 2>&1 < /dev/null & | |
| nohup /var/lib/mysql/mysql-state-monitor >/var/lib/mysql/mysql-state-monitor.log 2>&1 </dev/null & |
hors
requested changes
Dec 5, 2024
pull-request-size
bot
added
size/XL
hors
approved these changes
Dec 6, 2024
commit: 02d856a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
The liveness-check.sh and readiness-check.sh did not use /var/lib/mysql/mysql.state because MYSQL_VERSION was not set.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Define MYSQL_VERSION for readiness-check.sh did not use /var/lib/mysql/mysql.state
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability