Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPXC-1520 Set the default value of the enableVolumeExpansion param to false to match v1.15.1 #1896

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

ptankov
Copy link
Contributor

@ptankov ptankov commented Dec 4, 2024

CHANGE DESCRIPTION

Problem:
Short explanation of the problem.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PXC version?
  • Does the change support oldest and newest supported Kubernetes version?

Copy link
Collaborator

@hors hors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptankov please add task number into PR description

@ptankov
Copy link
Contributor Author

ptankov commented Dec 5, 2024

@ptankov please add task number into PR description

I didn't think a task was needed for such a trivial change.

@hors
Copy link
Collaborator

hors commented Dec 5, 2024

@ptankov please add task number into PR description

I didn't think a task was needed for such a trivial change.

All PRs should have it

@ptankov ptankov changed the title Set the default value of the enableVolumeExpansion param to false to match v1.15.1 K8SPXC-1520 Set the default value of the enableVolumeExpansion param to false to match v1.15.1 Dec 5, 2024
@ptankov ptankov requested a review from hors December 5, 2024 16:36
@ptankov
Copy link
Contributor Author

ptankov commented Dec 5, 2024

@ptankov please add task number into PR description

I didn't think a task was needed for such a trivial change.

All PRs should have it

done

@hors hors merged commit 24f0615 into main Dec 5, 2024
15 of 16 checks passed
@hors hors deleted the default_enableVolumeExpansion_to_false branch December 5, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants