-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPXC-1367: add readinessProbes
, livenessProbes
fields for pmm
#1935
Open
pooknull
wants to merge
2
commits into
main
Choose a base branch
from
dev/K8SPXC-1367
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+907
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
requested review from
tplavcic,
nmarukovich,
ptankov,
jvpasinatto,
eleo007,
hors,
egegunes and
inelpandzic
as code owners
January 8, 2025 13:39
pooknull
changed the title
K8SPXC-1367: add
K8SPXC-1367: add Jan 8, 2025
readinessProbes
, livenessProbes
fields for pmm c…readinessProbes
, livenessProbes
fields for pmm
hors
requested changes
Jan 13, 2025
@@ -583,6 +583,18 @@ spec: | |||
# proxysqlParams: "--custom-labels=CUSTOM-LABELS" | |||
# containerSecurityContext: | |||
# privileged: false | |||
# readinessProbes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add these options to helm chart as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit: 66deb73 |
egegunes
approved these changes
Jan 21, 2025
gkech
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPXC-1367
DESCRIPTION
This PR adds new fields
.spec.pmm.readinessProbes
and.spec.pmm.livenessProbes
to thecr.yaml
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability