Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXC-3546: [MTR] Fix failing keyring_vault sute tests #1792

Open
wants to merge 1 commit into
base: 8.0
Choose a base branch
from

Conversation

voodam
Copy link
Contributor

@voodam voodam commented May 4, 2023

https://jira.percona.com/browse/PXC-3546

All tests had the same cause of failure: keyring_vault plugin installation requires keyring_vault_config variable with valid data in the file. Setting this variable at the time of the test run is not possible as the file is generated within the test itself. Restarting the server solved the problem.

This breaking change has been made intentionally in PXC-2135 (commit b58c1d1). Before the change plugin was loaded without valid or any keyring_vault_config file, so we could SET that plugin variable.

Reasons for deletion:

  • keyring_vault_timeout: relies on keyring_vault_config with invalid data, which is now impossible.

@voodam
Copy link
Contributor Author

voodam commented May 4, 2023

@voodam
Copy link
Contributor Author

voodam commented May 5, 2023

Jenkins is not configured to be used with the vault probably. I used Hashicorp on the local machine.

@voodam voodam requested a review from kamil-holubicki May 5, 2023 07:39

--replace_result $MYSQLTEST_VARDIR MYSQLTEST_VARDIR
eval SET @@global.keyring_vault_config="$vault_conf_file";
--let $keyring_restart_param = restart: $KEYRING_VAULT_PLUGIN_OPT $KEYRING_VAULT_PLUGIN_EARLY_LOAD --keyring_vault_config=$vault_conf_file --innodb-sort-buffer-size=64k --innodb_encrypt_online_alter_logs=ON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the commit message that explains, why the suite works in Percona Server.

https://jira.percona.com/browse/PXC-3546

All tests had the same cause of failure: keyring_vault plugin installation requires keyring_vault_config variable with valid data in the file. Setting this variable at the time of the test run is not possible as the file is generated within the test itself. Restarting the server solved the problem.

This breaking change has been made intentionally in PXC-2135 (commit b58c1d1). Before the change plugin was loaded without valid or any keyring_vault_config file, so we could SET that plugin variable.

Reasons for deletion:
- keyring_vault_timeout: relies on keyring_vault_config with invalid data, which is now impossible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants