Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12223 added test for the clickhouse version #644

Merged
merged 3 commits into from
Oct 16, 2023
Merged

PMM-12223 added test for the clickhouse version #644

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c49a2f
PMM-12223 added test for the clickhouse version
Oct 13, 2023
0d3ca17
PMM-12223 adjusted version
Oct 13, 2023
d491994
PMM-12223 fixed var define
Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pmm-tests/check_upgrade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def verify_command(command):

def main():
args = parse_args()
pmm_minor_v = int(args.version.split('.')[1])

if args.env in "ami":
verify_command('rpm -qa | grep percona-qan-api2-' + args.version)
Expand Down Expand Up @@ -60,6 +61,11 @@ def main():
verify_command(f"docker exec {pmm_server_docker_container} rpm -qa | grep percona-qan-api2-{args.version}")
verify_command(
f"docker exec {pmm_server_docker_container} rpm -qa | grep percona-dashboards-{args.version}")

### PMM-12223 - Verify Clickhouse is v22.8 or later since 2.41.0
Copy link
Collaborator

@saikumar-vs saikumar-vs Oct 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like u mean v23.8 in the comment ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, no - it's a copy of the Ticket's title: see https://jira.percona.com/browse/PMM-12223
But I suppose you're right and I will change the it be more accurate in the sibling PR: #645

if pmm_minor_v >= 41:
verify_command(f"docker exec {pmm_server_docker_container} clickhouse local --version | grep 23.8.2.7")

if args.version != "2.25.0":
verify_command(f"docker exec {pmm_server_docker_container} rpm -qa | grep pmm-update-{args.version}")
verify_command(f"docker exec {pmm_server_docker_container} rpm -qa | grep pmm-managed-{args.version}")
Expand Down Expand Up @@ -96,7 +102,7 @@ def main():

docker_version = os.getenv("DOCKER_VERSION")
do_docker_way = os.getenv("PERFORM_DOCKER_WAY_UPGRADE")
pmm_minor_v = int(args.version.split('.')[1])

grafana_cli = "grafana cli" if pmm_minor_v >= 39 else "grafana-cli"

### PMM-T1758 - Verify vertamedia-clickhouse-datasource plugin is not installed after upgrade to 2.38.0
Expand Down