-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-7 migrated PMM container components tests to unittest #645
Conversation
# Conflicts: # pmm-tests/check_upgrade.py
Passing logs: https://pmm.cd.percona.com/blue/organizations/jenkins/pmm2-upgrade-tests/detail/pmm2-upgrade-tests/33354/pipeline/110 |
looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvements, thanks for working on this.
This change is not required at this time
Currently will fail until percona/pmm#2489 will be merged.
could be tested on PMM-12223 FB ex:
perconalab/pmm-server-fb:PR-3393-e534bc6
the usage is the same, but unittest output is more informative and all tests are executed: