PMM-8430 Add retention to backup scheduling (#764)

* PMM-8430 Add retention to backup scheduling * PMM-8430 Infinity ->unlimited
percona · Jul 30, 2021 · 154612d · 154612d
1 parent 685e1d7
commit 154612d
Show file tree

Hide file tree

Showing 8 changed files with 243 additions and 150 deletions.
diff --git a/api/managementpb/backup/backups.pb.go b/api/managementpb/backup/backups.pb.go
diff --git a/api/managementpb/backup/backups.proto b/api/managementpb/backup/backups.proto
@@ -97,6 +97,8 @@ message ScheduledBackup {
   google.protobuf.Timestamp last_run = 16;
   // Next run.
   google.protobuf.Timestamp next_run = 17;
+  // How many artifacts keep. 0 - unlimited.
+  uint32 retention = 18;
 }
 
 message ScheduleBackupRequest {
@@ -130,6 +132,8 @@ message ScheduleBackupRequest {
   //uint32 retry_times = 8;
   // If scheduling is enabled.
   bool enabled = 9;
+  // How many artifacts keep. 0 - unlimited.
+  uint32 retention = 10;
 }
 
 message ScheduleBackupResponse {
@@ -162,6 +166,8 @@ message ChangeScheduledBackupRequest {
   // How many times to retry a failed backup before giving up.
   //google.protobuf.UInt32Value retry_times = 8;
 
+  // How many artifacts keep. 0 - unlimited.
+  google.protobuf.UInt32Value retention = 9;
 }
 
 message ChangeScheduledBackupResponse {}

diff --git a/api/managementpb/backup/backups.validator.pb.go b/api/managementpb/backup/backups.validator.pb.go
diff --git a/api/managementpb/backup/json/backup.json b/api/managementpb/backup/json/backup.json
@@ -273,6 +273,12 @@
                   "type": "string",
                   "x-order": 4
                 },
+                "retention": {
+                  "description": "How many artifacts keep. 0 - unlimited.",
+                  "type": "integer",
+                  "format": "int64",
+                  "x-order": 6
+                },
                 "scheduled_backup_id": {
                   "type": "string",
                   "x-order": 0
@@ -418,6 +424,12 @@
                         "format": "date-time",
                         "x-order": 13
                       },
+                      "retention": {
+                        "description": "How many artifacts keep. 0 - unlimited.",
+                        "type": "integer",
+                        "format": "int64",
+                        "x-order": 14
+                      },
                       "scheduled_backup_id": {
                         "description": "Machine-readable ID.",
                         "type": "string",
@@ -690,6 +702,12 @@
                   "type": "string",
                   "x-order": 4
                 },
+                "retention": {
+                  "description": "How many artifacts keep. 0 - unlimited.",
+                  "type": "integer",
+                  "format": "int64",
+                  "x-order": 7
+                },
                 "service_id": {
                   "description": "Service identifier where backup should be performed.",
                   "type": "string",

diff --git a/api/managementpb/backup/json/client/backups/change_scheduled_backup_responses.go b/api/managementpb/backup/json/client/backups/change_scheduled_backup_responses.go
diff --git a/api/managementpb/backup/json/client/backups/list_scheduled_backups_responses.go b/api/managementpb/backup/json/client/backups/list_scheduled_backups_responses.go
diff --git a/api/managementpb/backup/json/client/backups/schedule_backup_responses.go b/api/managementpb/backup/json/client/backups/schedule_backup_responses.go
diff --git a/api/swagger/swagger-dev.json b/api/swagger/swagger-dev.json
@@ -24923,6 +24923,12 @@
                   "description": "Human-readable description.",
                   "type": "string",
                   "x-order": 5
+                },
+                "retention": {
+                  "description": "How many artifacts keep. 0 - unlimited.",
+                  "type": "integer",
+                  "format": "int64",
+                  "x-order": 6
                 }
               }
             }
@@ -25084,6 +25090,12 @@
                         "type": "string",
                         "format": "date-time",
                         "x-order": 13
+                      },
+                      "retention": {
+                        "description": "How many artifacts keep. 0 - unlimited.",
+                        "type": "integer",
+                        "format": "int64",
+                        "x-order": 14
                       }
                     }
                   },
@@ -25341,6 +25353,12 @@
                   "description": "Delay between each retry. Should have a suffix in JSON: 1s, 1m, 1h.\ngoogle.protobuf.Duration retry_interval = 7;\nHow many times to retry a failed backup before giving up.\nuint32 retry_times = 8;\nIf scheduling is enabled.",
                   "type": "boolean",
                   "x-order": 6
+                },
+                "retention": {
+                  "description": "How many artifacts keep. 0 - unlimited.",
+                  "type": "integer",
+                  "format": "int64",
+                  "x-order": 7
                 }
               }
             }