Skip to content

Commit

Permalink
PMM-9312 MongoDB enable all collectors (#811)
Browse files Browse the repository at this point in the history 
* PMM-9246 Extended MongoDB message

* PMM-9312 MongoDB enable all collectors

Added a field to indicate all collectors in MongoDB exporter should be
enabled.
This is necessary because by default some collectors are disabled like
collstats and indexstats.

* PMM-9312 Merged PMM-9246 - extended message for Mongo inventory

* trigger
  • Loading branch information
@percona-csalguero
percona-csalguero authored Dec 30, 2021
1 parent 8eea1aa commit 5e1fe3c
Show file tree
Hide file tree
Showing 13 changed files with 1,998 additions and 1,586 deletions.
3,147 changes: 1,592 additions & 1,555 deletions api/inventorypb/agents.pb.go
View file

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions api/inventorypb/agents.proto
View file
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,13 @@ message MongoDBExporter {
AgentStatus status = 9;
// Listen port for scraping metrics.
uint32 listen_port = 10;
// List of colletions to get stats from. Can use *
repeated string stats_collections = 13;
// Collections limit. Only get Databases and collection stats if the total number of collections in the server
// is less than this value. 0: no limit
int32 collections_limit = 14;
// Enable All collectors.
bool enable_all_collectors = 15;
}

// PostgresExporter runs on Generic or Container Node and exposes PostgreSQL Service metrics.
Expand Down
10 changes: 10 additions & 0 deletions api/inventorypb/json/client/agents/add_mongo_db_exporter_responses.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions api/inventorypb/json/client/agents/change_mongo_db_exporter_responses.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions api/inventorypb/json/client/agents/get_agent_responses.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions api/inventorypb/json/client/agents/list_agents_responses.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

76 changes: 76 additions & 0 deletions api/inventorypb/json/inventorypb.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,12 @@
"type": "string",
"x-order": 0
},
"collections_limit": {
"type": "integer",
"format": "int32",
"title": "Collections limit. Only get Databases and collection stats if the total number of collections in the server\nis less than this value. 0: no limit",
"x-order": 13
},
"custom_labels": {
"description": "Custom user-assigned labels.",
"type": "object",
Expand All @@ -549,6 +555,11 @@
},
"x-order": 9
},
"enable_all_collectors": {
"description": "Enable All collectors.",
"type": "boolean",
"x-order": 14
},
"listen_port": {
"description": "Listen port for scraping metrics.",
"type": "integer",
Expand All @@ -570,6 +581,14 @@
"type": "string",
"x-order": 3
},
"stats_collections": {
"type": "array",
"title": "List of colletions to get stats from. Can use *",
"items": {
"type": "string"
},
"x-order": 12
},
"status": {
"description": "AgentStatus represents actual Agent status.\n\n - STARTING: Agent is starting.\n - RUNNING: Agent is running.\n - WAITING: Agent encountered error and will be restarted automatically soon.\n - STOPPING: Agent is stopping.\n - DONE: Agent finished.\n - UNKNOWN: Agent is not connected, we don't know anything about it's state.",
"type": "string",
Expand Down Expand Up @@ -3313,6 +3332,12 @@
"type": "string",
"x-order": 0
},
"collections_limit": {
"type": "integer",
"format": "int32",
"title": "Collections limit. Only get Databases and collection stats if the total number of collections in the server\nis less than this value. 0: no limit",
"x-order": 13
},
"custom_labels": {
"description": "Custom user-assigned labels.",
"type": "object",
Expand All @@ -3334,6 +3359,11 @@
},
"x-order": 9
},
"enable_all_collectors": {
"description": "Enable All collectors.",
"type": "boolean",
"x-order": 14
},
"listen_port": {
"description": "Listen port for scraping metrics.",
"type": "integer",
Expand All @@ -3355,6 +3385,14 @@
"type": "string",
"x-order": 3
},
"stats_collections": {
"type": "array",
"title": "List of colletions to get stats from. Can use *",
"items": {
"type": "string"
},
"x-order": 12
},
"status": {
"description": "AgentStatus represents actual Agent status.\n\n - STARTING: Agent is starting.\n - RUNNING: Agent is running.\n - WAITING: Agent encountered error and will be restarted automatically soon.\n - STOPPING: Agent is stopping.\n - DONE: Agent finished.\n - UNKNOWN: Agent is not connected, we don't know anything about it's state.",
"type": "string",
Expand Down Expand Up @@ -5538,6 +5576,12 @@
"type": "string",
"x-order": 0
},
"collections_limit": {
"type": "integer",
"format": "int32",
"title": "Collections limit. Only get Databases and collection stats if the total number of collections in the server\nis less than this value. 0: no limit",
"x-order": 13
},
"custom_labels": {
"description": "Custom user-assigned labels.",
"type": "object",
Expand All @@ -5559,6 +5603,11 @@
},
"x-order": 9
},
"enable_all_collectors": {
"description": "Enable All collectors.",
"type": "boolean",
"x-order": 14
},
"listen_port": {
"description": "Listen port for scraping metrics.",
"type": "integer",
Expand All @@ -5580,6 +5629,14 @@
"type": "string",
"x-order": 3
},
"stats_collections": {
"type": "array",
"title": "List of colletions to get stats from. Can use *",
"items": {
"type": "string"
},
"x-order": 12
},
"status": {
"description": "AgentStatus represents actual Agent status.\n\n - STARTING: Agent is starting.\n - RUNNING: Agent is running.\n - WAITING: Agent encountered error and will be restarted automatically soon.\n - STOPPING: Agent is stopping.\n - DONE: Agent finished.\n - UNKNOWN: Agent is not connected, we don't know anything about it's state.",
"type": "string",
Expand Down Expand Up @@ -6727,6 +6784,12 @@
"type": "string",
"x-order": 0
},
"collections_limit": {
"type": "integer",
"format": "int32",
"title": "Collections limit. Only get Databases and collection stats if the total number of collections in the server\nis less than this value. 0: no limit",
"x-order": 13
},
"custom_labels": {
"description": "Custom user-assigned labels.",
"type": "object",
Expand All @@ -6748,6 +6811,11 @@
},
"x-order": 9
},
"enable_all_collectors": {
"description": "Enable All collectors.",
"type": "boolean",
"x-order": 14
},
"listen_port": {
"description": "Listen port for scraping metrics.",
"type": "integer",
Expand All @@ -6769,6 +6837,14 @@
"type": "string",
"x-order": 3
},
"stats_collections": {
"type": "array",
"title": "List of colletions to get stats from. Can use *",
"items": {
"type": "string"
},
"x-order": 12
},
"status": {
"description": "AgentStatus represents actual Agent status.\n\n - STARTING: Agent is starting.\n - RUNNING: Agent is running.\n - WAITING: Agent encountered error and will be restarted automatically soon.\n - STOPPING: Agent is stopping.\n - DONE: Agent finished.\n - UNKNOWN: Agent is not connected, we don't know anything about it's state.",
"type": "string",
Expand Down
13 changes: 13 additions & 0 deletions api/managementpb/json/client/mongo_db/add_mongo_db_responses.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 24 additions & 0 deletions api/managementpb/json/managementpb.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2404,6 +2404,11 @@
},
"x-order": 22
},
"enable_all_collectors": {
"type": "boolean",
"title": "Enable all collectors",
"x-order": 28
},
"environment": {
"description": "Environment name.",
"type": "string",
Expand Down Expand Up @@ -2528,6 +2533,12 @@
"type": "string",
"x-order": 0
},
"collections_limit": {
"type": "integer",
"format": "int32",
"title": "Collections limit. Only get Databases and collection stats if the total number of collections in the server\nis less than this value. 0: no limit",
"x-order": 13
},
"custom_labels": {
"description": "Custom user-assigned labels.",
"type": "object",
Expand All @@ -2549,6 +2560,11 @@
},
"x-order": 9
},
"enable_all_collectors": {
"description": "Enable All collectors.",
"type": "boolean",
"x-order": 14
},
"listen_port": {
"description": "Listen port for scraping metrics.",
"type": "integer",
Expand All @@ -2570,6 +2586,14 @@
"type": "string",
"x-order": 3
},
"stats_collections": {
"type": "array",
"title": "List of colletions to get stats from. Can use *",
"items": {
"type": "string"
},
"x-order": 12
},
"status": {
"description": "AgentStatus represents actual Agent status.\n\n - STARTING: Agent is starting.\n - RUNNING: Agent is running.\n - WAITING: Agent encountered error and will be restarted automatically soon.\n - STOPPING: Agent is stopping.\n - DONE: Agent finished.\n - UNKNOWN: Agent is not connected, we don't know anything about it's state.",
"type": "string",
Expand Down
Loading

0 comments on commit 5e1fe3c

Please sign in to comment.