PMM-11714 Fix tests.

percona · Sep 7, 2023 · 65f665e · 65f665e
1 parent e01e88c
commit 65f665e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/admin/commands/management/register_test.go b/admin/commands/management/register_test.go
@@ -1,9 +1,11 @@
 package management
 
 import (
-	"github.com/percona/pmm/api/managementpb/json/client/node"
-	"github.com/stretchr/testify/assert"
 	"testing"
+
+	"github.com/stretchr/testify/assert"
+
+	"github.com/percona/pmm/api/managementpb/json/client/node"
 )
 
 func TestRegisterResult(t *testing.T) {

diff --git a/managed/services/management/mock_api_key_provider_test.go b/managed/services/management/mock_api_key_provider_test.go
diff --git a/managed/services/management/node.go b/managed/services/management/node.go
@@ -143,7 +143,10 @@ func (s *NodeService) Register(ctx context.Context, req *managementpb.RegisterNo
 	// get authorization from headers.
 	md, ok := metadata.FromIncomingContext(ctx)
 	if !ok {
-		return nil, fmt.Errorf("cannot get headers from metadata")
+		msg := "Couldn't create Admin API Key: cannot get headers from metadata"
+		logrus.Errorln(msg)
+		res.Warning = msg
+		return res, nil
 	}
 	authorizationHeaders := md.Get("Authorization")
 	if len(authorizationHeaders) == 0 {

diff --git a/managed/services/management/node_test.go b/managed/services/management/node_test.go
@@ -17,6 +17,7 @@ package management
 
 import (
 	"context"
+	"google.golang.org/grpc/metadata"
 	"testing"
 
 	"github.com/google/uuid"
@@ -53,6 +54,7 @@ func TestNodeService(t *testing.T) {
 
 				require.NoError(t, sqlDB.Close())
 			}
+			metadata.AppendToOutgoingContext(ctx, "Authorization", "Basic username:password")
 			var apiKeyProvider mockApiKeyProvider
 			apiKeyProvider.Test(t)
 			apiKeyProvider.On("CreateAdminAPIKey", ctx, mock.AnythingOfType("string")).Return(int64(0), "test-token", nil)