Skip to content

Commit

Permalink
PMM-7 improve contribution (#967)
Browse files Browse the repository at this point in the history
* PMM-7 improve contribution

* Update CODEOWNERS

* more codeownership rules

* fix codeowners

* restructure documentation and add common tech (#973)

* restructure documentation and add common tech

Co-Authored-By: Alex Tymchuk <[email protected]>
Co-Authored-By: Alexey Palazhchenko <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Alex Tymchuk <[email protected]>

* fix markdown dir

* fix kingpin

* ignore docs in all workflows

* Update docs/process/common_tech_lib_approaches.md

Co-authored-by: Nurlan Moldomurov <[email protected]>

* only path or path-ignore could be there. fix pattern

* fix doc pipeline

Co-authored-by: Alex Tymchuk <[email protected]>
Co-authored-by: Alexey Palazhchenko <[email protected]>
Co-authored-by: Nurlan Moldomurov <[email protected]>

* PMM-9965 Apply changes in monorepo (#971)

This changes were already approved and tested.

* Bump github.com/aws/aws-sdk-go from 1.44.39 to 1.44.42 (#977)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.39 to 1.44.42.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.44.39...v1.44.42)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* PMM-9913 Added temp cleanup on agent start/stop (#923)

* PMM-9913 Added temp cleanup on agent start/stop

* Fix DBAAS dependency version (#982)

* cleanup (#961)

* Bump github.com/stretchr/testify from 1.7.2 to 1.7.5 (#979)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.2 to 1.7.5.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.2...v1.7.5)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* PMM-10082 Remove ssh-keygen dependency (#981)

* PMM-10082 Remove ssh-keygen dependency
* PMM-10082 Skip test check updates

* PMM-7462 Compares env var to settings (#965)

* PMM-7462 Compares env var to settings

- Settings send all configuration in a request
- This triggered an error if a setting was configured in env var
- This validates if the env var setting did not change

* PMM-10145 Handle RDS not having an endpoint (#955)

* PMM-10145 Handle RDS not having an endpoint

- RDS instances in state "Creating" do not have an endpoint yet.
- When discovering such instances we panicked

* Bump github.com/bufbuild/buf from 1.5.0 to 1.6.0 in /tools (#976)

Bumps [github.com/bufbuild/buf](https://github.com/bufbuild/buf) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/bufbuild/buf/releases)
- [Changelog](https://github.com/bufbuild/buf/blob/main/CHANGELOG.md)
- [Commits](bufbuild/buf@v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/bufbuild/buf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* PMM-10231 Revert of defaults-file and credentials-source. (#992)

* PMM-10231 Revert of defaults-file.

* PMM-10231 Revert of credentials-sources.

* PMM-10231 Revert of defaults-file tests.

* PMM-10231 Revert of defaults-file - api tests.

* Update CONTRIBUTING.md (#994)

* PMM-9510: Remove tail with scrape resolution from job label (#980)

* Remove tail with scrape value from job

* Fix typo

* PMM-9510 Refactoring

Co-authored-by: Artem Gavrilov <[email protected]>
Co-authored-by: Denys Kondratenko <[email protected]>

* PMM-7 improve contribution guide (#997)

* PMM-10170 unlock all severities (#959)

* PMM-10170 add support for all severity levels in response

* improve api tests readme

* continue on unknown severity

Co-authored-by: Fábio Silva <[email protected]>

* PMM-10142 MySQL explain fix. (#991)

* PMM-10142 API changes.

* PMM-10142 Changes.

* PMM-10142 Gen.

* PMM-10142 Gen.

* PMM-10142 Empty line.

* PMM-10142 Changes.

* PMM-10142 Fix blacklisted package.

* PMM-10142 Changes.

* trigger

* trigger

* PMM-9320: fix username/password incorrect escape (#949)

* Bump github.com/brianvoe/gofakeit/v6 from 6.16.0 to 6.17.0 (#1006)

Bumps [github.com/brianvoe/gofakeit/v6](https://github.com/brianvoe/gofakeit) from 6.16.0 to 6.17.0.
- [Release notes](https://github.com/brianvoe/gofakeit/releases)
- [Commits](brianvoe/gofakeit@v6.16.0...v6.17.0)

---
updated-dependencies:
- dependency-name: github.com/brianvoe/gofakeit/v6
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/ClickHouse/clickhouse-go/v2 from 2.1.0 to 2.2.0 (#1007)

Bumps [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/ClickHouse/clickhouse-go/releases)
- [Commits](ClickHouse/clickhouse-go@v2.1.0...v2.2.0)

---
updated-dependencies:
- dependency-name: github.com/ClickHouse/clickhouse-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* PMM-6384 Fixed docker-compose for M1 CPUs (#999)

* return common test for docs (#1011)

Common tests are required to pass, and it is hard to workaround this report in Actions.

* fix issue in get config (#1000)

Co-authored-by: Carlos Salguero <[email protected]>

* Bump github.com/aws/aws-sdk-go from 1.44.42 to 1.44.47 (#1010)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.42 to 1.44.47.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.44.42...v1.44.47)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/go-co-op/gocron from 1.14.0 to 1.15.0 (#1005)

Bumps [github.com/go-co-op/gocron](https://github.com/go-co-op/gocron) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/go-co-op/gocron/releases)
- [Commits](go-co-op/gocron@v1.14.0...v1.15.0)

---
updated-dependencies:
- dependency-name: github.com/go-co-op/gocron
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/stretchr/testify from 1.7.5 to 1.8.0 (#1009)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.5 to 1.8.0.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.5...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* PMM-7326 Help text update (#1015)

* PMM-7 fix link to pmm-managed (#1017)

* fallback to original DSN if it is non-URI (#1018)

* Make imports tests work with modules (#987)

* PMM-10078 Extract portal client, add dev env variables for portal address overwriting (#958)

* PMM-10078 Extract portal client, add dev env variables for portal address overwriting

* PMM-10078 Refactoring

* PMM-10078 Refactoring

* PMM-10078 Refactoring

* Fix DBAAS dependency version

* PMM-10078 Use warns instead of errors for removed test env variables

* PMM-10078 Fix tests

* PMM-10078 Add test env variables to CONTRIBUTING.md

* PMM-10301 Detailed version of MySQL (#1020)

* Update config.default.yml

* Update managed/services/telemetry/config.default.yml

Co-authored-by: Nurlan Moldomurov <[email protected]>

* fix the metrics name

* PMM-10301 combined query

* Update config.default.yml

Co-authored-by: Nurlan Moldomurov <[email protected]>

* PMM-7 Bump golangci-lint deps. (#1023)

* Bump golangci-lint deps.

* Bump golangci-lint deps.

* Bump github.com/minio/minio-go/v7 from 7.0.28 to 7.0.31 (#1019)

Bumps [github.com/minio/minio-go/v7](https://github.com/minio/minio-go) from 7.0.28 to 7.0.31.
- [Release notes](https://github.com/minio/minio-go/releases)
- [Commits](minio/minio-go@v7.0.28...v7.0.31)

---
updated-dependencies:
- dependency-name: github.com/minio/minio-go/v7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/hashicorp/go-version from 1.5.0 to 1.6.0 (#1013)

Bumps [github.com/hashicorp/go-version](https://github.com/hashicorp/go-version) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/hashicorp/go-version/releases)
- [Changelog](https://github.com/hashicorp/go-version/blob/main/CHANGELOG.md)
- [Commits](hashicorp/go-version@v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-version
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* PMM-7 More codeownership rules

* Update CODEOWNERS

Co-authored-by: Alex Tymchuk <[email protected]>
Co-authored-by: Denys Kondratenko <[email protected]>
Co-authored-by: Alexey Palazhchenko <[email protected]>
Co-authored-by: Carlos Salguero <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Taras Shcherban <[email protected]>
Co-authored-by: Artem Gavrilov <[email protected]>
Co-authored-by: Alexey Mukas <[email protected]>
Co-authored-by: Michal Kralik <[email protected]>
Co-authored-by: Przemyslaw Kadej <[email protected]>
Co-authored-by: Anton Bystrov <[email protected]>
Co-authored-by: Michael Okoko <[email protected]>
Co-authored-by: Fábio Silva <[email protected]>
Co-authored-by: Jiří Čtvrtka <[email protected]>
Co-authored-by: Andrew Minkin <[email protected]>
Co-authored-by: Nikita Beletskii <[email protected]>
Co-authored-by: Roma Novikov <[email protected]>
Co-authored-by: Pavel Khripkov <[email protected]>
  • Loading branch information
19 people authored Jul 12, 2022
1 parent 1ba7f3b commit 6ce95df
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
9 changes: 8 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
* @BupycHuk
/admin/ @michal-kralik
/agent/agents/postgres/ @JiriCtvrtka
/agent/actions/ @artemgavrilov
/agent/jobs/ @artemgavrilov
/api/ @BupycHuk
/docs/api/ @atymchuk
/managed/services/checks/ @idoqo
/managed/ @BupycHuk @artemgavrilov
/api-tests/ @BupycHuk @artemgavrilov
/managed/data/iatemplates/ @BupycHuk @artemgavrilov
go.mod @BupycHuk @artemgavrilov
4 changes: 2 additions & 2 deletions docs/process/GIT_AND_GITHUB.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ While addressing review comments push the requested changes as a new commit inst
- [x] If change requests were made, all changes need to be resolved and re-approved by the original reviewers.
- [x] Task should have Ready for merge status
- [x] If all conditions for a successful merge are met (checks pass, code reviewed and approved, changes resolved and re-approved), ONLY then the PR can me merged:
* If a PR has Assignees, then the last approver should ping them in in the appropriate dev channel. Typically that means they want to merge several PRs in a feature build together.
* If a PR has no Assignees, then the last approver must assign it to the author and ping them on Slack.
* If an author has write permissions. An author should merge the PR.
* If an author doesn't have a write permissions, then author should ask someone with write permissions to merge.
* If required checks fail for a confusing reason or some non-required checks fail for a long time, ping the appropriate dev channel.
- [x] A PR should be merged with the "Squash and Merge" button (the code owner should set this as the only option in the repository settings).
- [x] Never leave PRs fully approved, unassigned, and not merged.
Expand Down

0 comments on commit 6ce95df

Please sign in to comment.