Skip to content

Commit

Permalink
PMM-12375 fix the tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex Tymchuk committed Sep 18, 2023
1 parent 6f62f3c commit 8319521
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 0 additions & 2 deletions agent/connectionchecker/connection_checker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,15 +161,13 @@ func TestConnectionChecker(t *testing.T) {

// Use MySQL for ProxySQL tests for now.
// TODO https://jira.percona.com/browse/PMM-4930
// NOTE the above will also fix the error `Unknown system variable 'admin-version'`
{
name: "ProxySQL/MySQL",
req: &agentpb.CheckConnectionRequest{
Dsn: "root:root-password@tcp(127.0.0.1:3306)/?clientFoundRows=true&parseTime=true&timeout=1s",
Type: inventorypb.ServiceType_PROXYSQL_SERVICE,
Timeout: durationpb.New(3 * time.Second),
},
expectedErr: `Unknown system variable 'admin-version'`,
},
{
name: "ProxySQL/MySQL wrong params",
Expand Down
2 changes: 2 additions & 0 deletions agent/serviceinfobroker/service_info_broker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,13 +161,15 @@ func TestServiceInfoBroker(t *testing.T) {

// Use MySQL for ProxySQL tests for now.
// TODO https://jira.percona.com/browse/PMM-4930
// NOTE the above will also fix the error `Unknown system variable 'admin-version'`
{
name: "ProxySQL/MySQL",
req: &agentpb.ServiceInfoRequest{
Dsn: "root:root-password@tcp(127.0.0.1:3306)/?clientFoundRows=true&parseTime=true&timeout=1s",
Type: inventorypb.ServiceType_PROXYSQL_SERVICE,
Timeout: durationpb.New(3 * time.Second),
},
expectedErr: `Unknown system variable 'admin-version'`,
},
{
name: "ProxySQL/MySQL wrong params",
Expand Down

0 comments on commit 8319521

Please sign in to comment.