Godot linter (#2445)

* Install the CodeSee workflow. Learn more at https://docs.codesee.io

* changed the value of the linter-rule godot period: true from false

* made changes to store file in agent directory in taillog folder

* made changes to agent_types.go file located in /pmm/api/inventorypb/types

* made changes to agent_types.go file located in /pmm/api/inventorypb/types

* made changes to node_types.go file located in /pmm/api/inventorypb/types

* made changes to service_types.go file located in /pmm/api/inventorypb/types

* made changes to service_types.go file located in /pmm/api/inventorypb/types

* made changes to common.go file located in /pmm/admin/pkg/common

* made changes to global.go file located in /pmm/admin/cli/flags

* made changes to sqlrows.go file located in /pmm/utils/sqlrows

* made changes to grpc.go file located in /pmm/qan-api2/utils/logger

* made changes to logger.go file located in /pmm/qan-api2/utils/logger

* made changes to grpc.go file located in /pmm/managed/utils/logger

* made changes to logger.go file located in /pmm/managed/utils/logger

* made changes to style.go file located in pmm/admin/pkg/bubbles/styles

* made changes to size.go file located in pmm/admin/pkg/bubbles/progress

* made changes to client.go file located in pmm/admin/pkg/client

* made changes to service.go file located in pmm/agent/connectionuptime

* made changes to docker.go file located in pmm/dmin/pkg/docker

* made changes to service.go file located in pmm/agent/connectionuptime

* made changes to postgresql.go file located in pmm/agent/utils/version

* made changes to tarball.go file located in pmm/admin/pkg/client/tarball

* made changes to logger.go file located in pmm/agent/config

* made changes to logger.go file located in pmm/agent/config

* made changes to release.go file located in pmm/version/

* made changes to continuous_file_reader.go file located in pmm/agent/agents/mysql/slowlog/parser

* made changes to simple_file_reader.go file located in pmm/agent/agents/mysql/slowlog/parser

* made changes to nodeinfo.go.go file located in pmm/utils/nodeinfo/

* made changes to proxy.go file located in pmm/vmproxy/proxy/

* made changes to nodeinfo.go.go file located in pmm/agent/agents/mysql/slowlog/parser/

* made changes to sqlmetrics.go.go file located in pmm/utils/sqlmetrics/sqlmetrics

* made changes to cache.go.go file located in pmm/agent/agents/cache/

* made changes to metrics.go.go file located in pmm/managed/utils/irt/

* made changes to idgo file located in pmm/managed/utils/tests/

* made changes to action_model.go file located in pmmmanaged/models/

* made changes to kubernetes_helpers.go file located in managed/models/

* made changes to database.go.go file located in managed/services/dbaas/kubernetes/client/database/database.go

* made changes to helpers.go file located in api-tests/helpers.go:

* made changes to init.go file located in api-tests/init.go

* made changes to kubernetes_models.go file located in managed/models/

* made changes to location_model.go file located in pmm/managed/models/

* made changes to node_model.go file located in managed/models/node_model.go

* made changes to service_model.go file located in managed/models/service_model.go

* made changes to postgresql_version.go file located in managed/models/postgresql_version.go

* made changes to setup.go file located in admin/commands/base/

* made changes to supervisord.go file located in managed/services/supervisord/

* made changes to summary.go file located in admin/commands/summary.go

* made changes to interceptors.go file located in qan-api2/utils/interceptors/

* made changes to database_test.go file located in managed/models/

* made changes to agents.go file located in api/inventorypb/

* made changes to nodes.go file located in api/inventorypb/

* made changes to services.go file located in api/inventorypb/services.go

* made changes to services.go file located in api/inventorypb/services.go

* made changes to nodes_test.go file located in api/inventorypb/

* made changes to base.go file located in admin/commands/pmm/server/docker/

* made changes to base_test.go file located in admin/commands/pmm/server/docker/

* made changes to base.go file located in admin/commands/pmm/client/

* made changes to services_test.go.go file located in api/inventorypb/

* made changes to converters.go file located in managed/services/converters.go

* made changes to user.go file located in managed/services/user/user.go

* made changes to user.go file located in managed/services/user/user.go

* made changes to user.go file located in managed/services/user/user.go

* made changes to errors.go file located in utils/errors/errors.go

* made changes to errors.go file located in utils/errors/errors.go

* made changes to datasource_pmmdb_select.go.go file located in managed/services/telemetry/datasource_pmmdb_select.go

* made changes to datasource_qandb_select.go file located in managed/services/telemetry/datasource_qandb_select.go

* made changes to agent.go file located in api/agentpb/agent.go

* made changes to agent.go file located in api/agentpb/agent.go

* made changes to data_ingestion.go file located in qan-api2/models/data_ingestion.go

* made changes to cli.go file located in admin/cli/cli.go

* made changes to data_ingestion.go: file located in qan-api2/models/data_ingestion.go:

* made changes to datasource_victoria_metrics.go file located in managed/services/telemetry/datasource_victoria_metrics.go

* made changes to datasources.go file located in managed/services/telemetry/datasources.go

* made changes to deps.go file located in managed/services/telemetry/deps.go

* made changes to deps.go file located in managed/services/telemetry/deps.go

* made changes to telemetry.go file located in managed/services/telemetry/telemetry.go

* made changes to telemetry.go file located in managed/services/telemetry/telemetry.go

* made changes to rds.go file located in managed/services/management/rds.go

* made changes to bootstrap.go file located in admin/cmd/bootstrap.go

* made changes to rds.go file located in managed/services/management/rds.go

* made changes to rds.go file located in managed/services/management/rds.go

* made changes to grpc_extension.go file located in managed/utils/interceptors/grpc_extension.go

* made changes to interceptors.go: file located in managed/utils/interceptors/interceptors.go:

* made changes to mysql_restore_job.go file located in agent/runner/jobs/mysql_restore_job.go

* made changes to mysql_restore_job.go file located in agent/runner/jobs/mysql_restore_job.go

* made changes to pbm_helpers.go file located in agent/runner/jobs/pbm_helpers.go

* made changes to agent_local.go file located in agent/agentlocal/agent_local.go

* made changes to channel.go file located in agent/client/channel/channel.go

* made changes to channel.go file located in agent/client/channel/channel.go

* made changes to filters_test.go file located in qan-api2/services/analytics/filters_test.go

* made changes to object_details_test.go.go file located in qan-api2/services/analytics/

* made changes to profile_test.go file located in qan-api2/services/analytics/profile_test.go

* made changes to profile_test.go file located in qan-api2/services/analytics/profile_test.go

* made changes to process.go file located in agent/agents/process/process.go

* made changes to process.go file located in agent/agents/process/process.go

* made changes to alerts_service.go file located in managed/services/management/ia/alerts_service.go

* made changes to alerts_service.go file located in managed/services/management/ia/alerts_service.go

* made changes to agent/agents/noop/noop.go file located in agent/agents/noop/noop.go

* made changes to process.go file located in agent/agents/process/process.go

* made changes to agent/agents/process/process.go file located in agent/agents/process/process.go

* made changes to slowlog.go file located in agent/agents/mysql/slowlog/slowlog.go

* made changes to history.go file located in agent/agents/mysql/perfschema/history.go

* made changes to perfschema.go file located in agent/agents/mysql/perfschema/perfschema.go

* made changes to process_logger.go file located in agent/agents/process/process_logger.go

* made changes to pgstatmonitor.go file located in agent/agents/postgres/pgstatmonitor/pgstatmonitor.go

* made changes to pgstatmonitor_models.go file located in agent/agents/postgres/pgstatmonitor/pgstatmonitor_models.go

* made changes to alerts_service.go file located in managed/services/management/ia/alerts_service.go

* made changes to rules_service_test.go file located in managed/services/management/ia/rules_service_test.go

* made changes to pgstatmonitor_models.go file located in agent/agents/postgres/pgstatmonitor/pgstatmonitor_models.go

* made changes to perfschema.go file located in agent/agents/mysql/perfschema/perfschema.go

* made changes to perfschema.go file located in agent/agents/mysql/perfschema/perfschema.go

* made changes to summaries.go file located in agent/agents/mysql/perfschema/summaries.go

* made changes to pgstatstatements.go file located in agent/agents/postgres/pgstatstatements/pgstatstatements.go

* made changes to butils.go file located in agent/agents/postgres/pgstatstatements/utils.go

* made changes to common.go file located in agent/runner/actions/common.go

* made changes to main_test.go file located in managed/cmd/pmm-managed-starlark/main_test.go

* made changes to basic_auth.go file located in agent/client/basic_auth.go

* made changes to client.go file located in agent/client/client.go

* made changes to client.go file located in agent/client/client.go

* made changes to client.go file located in agent/client/client.go

* made changes to client.go file located in agent/client/client.go

* made changes to mongodb.go file located in agent/agents/mongodb/mongodb.go

* made changes to mongodb.go file located in agent/agents/mongodb/mongodb.go

* made changes to supervisor.go file located in agent/agents/supervisor/supervisor.go

* made changes to clients.go file located in agent/commands/clients.go

* removed the codesee-arch-diagram.yml~

---------

Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com>
Co-authored-by: vboxuser <[email protected]>
Co-authored-by: Alex Tymchuk <[email protected]>
Co-authored-by: Artem Gavrilov <[email protected]>

.golangci.yml

@@ -29,7 +29,7 @@ linters-settings:
 
   godot:
     capital: true
-    period: false
+    period: true
     scope: toplevel
     exclude:
       - go-sumtype:decl 

admin/cli/cli.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package cli stores cli configuration and common logic for commands
+// Package cli stores cli configuration and common logic for commands.
 package cli
 
 import (

admin/cli/flags/global.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package flags holds global flags
+// Package flags holds global flags.
 package flags
 
 import (

admin/cmd/bootstrap.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package cmd holds common logic used by commands
+// Package cmd holds common logic used by commands.
 package cmd
 
 import (

admin/commands/base/setup.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package base provides helpers for all commands
+// Package base provides helpers for all commands.
 package base
 
 import (

admin/commands/pmm/client/base.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package client holds the "pmm client" command
+// Package client holds the "pmm client" command.
 package client
 
 import "github.com/percona/pmm/admin/commands"

admin/commands/pmm/server/base.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package server holds the "pmm server" command
+// Package server holds the "pmm server" command.
 package server
 
 import (

admin/commands/pmm/server/docker/base.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package docker holds the "pmm server install docker" command
+// Package docker holds the "pmm server install docker" command.
 package docker
 
 import (

admin/commands/pmm/server/docker/base_test.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package docker holds the "pmm server install docker" command
+// Package docker holds the "pmm server install docker" command.
 package docker
 
 import (

admin/commands/summary.go

@@ -254,7 +254,7 @@ func getURL(ctx context.Context, url string) ([]byte, error) {
 	return b, nil
 }
 
-// downloadFile download file and includes into zip file
+// downloadFile download file and includes into zip file.
 func downloadFile(ctx context.Context, zipW *zip.Writer, url, fileName string) error {
 	b, err := getURL(ctx, url)
 	if err != nil {

admin/pkg/bubbles/progress/size.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package progress contains progress bar programs to be rendered with BubbleTea
+// Package progress contains progress bar programs to be rendered with BubbleTea.
 package progress
 
 import (

admin/pkg/bubbles/styles/styles.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package styles holds common styles for BubbleTea programs
+// Package styles holds common styles for BubbleTea programs.
 package styles
 
 import "github.com/charmbracelet/lipgloss"

admin/pkg/client/client.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package client provides common methods for working with pmm-client
+// Package client provides common methods for working with pmm-client.
 package client
 
 import (

admin/pkg/client/tarball/tarball.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package tarball holds logic for pmm-client tarball specific operations
+// Package tarball holds logic for pmm-client tarball specific operations.
 package tarball
 
 import (

admin/pkg/common/common.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package common holds common methods used in admin
+// Package common holds common methods used in admin.
 package common
 
 import (

admin/pkg/docker/docker.go

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package docker stores common functions for working with Docker
+// Package docker stores common functions for working with Docker.
 package docker
 
 import (

agent/agentlocal/agent_local.go

@@ -349,7 +349,7 @@ var (
 	_ agentlocalpb.AgentLocalServer = (*Server)(nil)
 )
 
-// addData add data to zip file
+// addData add data to zip file.
 func addData(zipW *zip.Writer, name string, data []byte) error {
 	f, err := zipW.Create(name)
 	if err != nil {

agent/agents/cache/cache.go

@@ -47,7 +47,7 @@ type Cache struct {
 	trimmedN  uint
 }
 
-// cacheItem is an element stored in Cache
+// cacheItem is an element stored in Cache.
 type cacheItem struct {
 	key   interface{}
 	value interface{}

agent/agents/mongodb/mongodb.go

@@ -119,7 +119,7 @@ func (m *MongoDB) Collect(ch chan<- prometheus.Metric) {
 	// This method is needed to satisfy interface.
 }
 
-// check interfaces
+// check interfaces.
 var (
 	_ prometheus.Collector = (*MongoDB)(nil)
 )

agent/agents/mysql/perfschema/history.go

@@ -25,7 +25,7 @@ import (
 	"github.com/percona/pmm/agent/agents/cache"
 )
 
-// historyCache is a wrapper for cache.Cache to use only with historyMap type
+// historyCache is a wrapper for cache.Cache to use only with historyMap type.
 type historyCache struct {
 	cache *cache.Cache
 }

agent/agents/mysql/perfschema/perfschema.go

@@ -47,7 +47,7 @@ type (
 	summaryMap map[string]*eventsStatementsSummaryByDigest
 )
 
-// mySQLVersion contains
+// mySQLVersion contains.
 type mySQLVersion struct {
 	version float64
 	vendor  string
@@ -107,7 +107,7 @@ type Params struct {
 	TLSSkipVerify          bool
 }
 
-// newPerfSchemaParams holds all required parameters to instantiate a new PerfSchema
+// newPerfSchemaParams holds all required parameters to instantiate a new PerfSchema.
 type newPerfSchemaParams struct {
 	Querier                *reform.Querier
 	DBCloser               io.Closer
@@ -520,7 +520,7 @@ func (m *PerfSchema) Collect(ch chan<- prometheus.Metric) {
 	}
 }
 
-// check interfaces
+// check interfaces.
 var (
 	_ prometheus.Collector = (*PerfSchema)(nil)
 )

agent/agents/mysql/perfschema/summaries.go

@@ -25,7 +25,7 @@ import (
 	"github.com/percona/pmm/agent/agents/cache"
 )
 
-// summaryCache is a wrapper for cache.Cache to use only with summaryMap type
+// summaryCache is a wrapper for cache.Cache to use only with summaryMap type.
 type summaryCache struct {
 	cache *cache.Cache
 }

agent/agents/mysql/slowlog/parser/continuous_file_reader.go

@@ -182,7 +182,7 @@ func (r *ContinuousFileReader) Metrics() *ReaderMetrics {
 	return &m
 }
 
-// check interfaces
+// check interfaces.
 var (
 	_ Reader = (*ContinuousFileReader)(nil)
 )

agent/agents/mysql/slowlog/parser/logger_test.go

@@ -40,5 +40,5 @@ func (tl *testLogger) Tracef(format string, v ...interface{}) {
 	tl.t.Logf("TRACE: "+format, v...)
 }
 
-// check interface
+// check interface.
 var _ Logger = (*testLogger)(nil)

agent/agents/mysql/slowlog/parser/simple_file_reader.go

@@ -76,7 +76,7 @@ func (r *SimpleFileReader) Metrics() *ReaderMetrics {
 	return &m
 }
 
-// check interfaces
+// check interfaces.
 var (
 	_ Reader = (*SimpleFileReader)(nil)
 )

agent/agents/mysql/slowlog/slowlog.go

@@ -724,7 +724,7 @@ func (s *SlowLog) Collect(ch chan<- prometheus.Metric) {
 	// This method is needed to satisfy interface.
 }
 
-// check interfaces
+// check interfaces.
 var (
 	_ prometheus.Collector = (*SlowLog)(nil)
 )

agent/agents/noop/noop.go

@@ -66,7 +66,7 @@ func (n *NoOp) Collect(ch chan<- prometheus.Metric) {
 	// This method is needed to satisfy interface.
 }
 
-// check interfaces
+// check interfaces.
 var (
 	_ prometheus.Collector = (*NoOp)(nil)
 )

agent/agents/postgres/pgstatmonitor/pgstatmonitor.go

@@ -724,5 +724,5 @@ func (m *PGStatMonitorQAN) Collect(ch chan<- prometheus.Metric) {
 	// This method is needed to satisfy interface.
 }
 
-// check interfaces
+// check interfaces.
 var _ prometheus.Collector = (*PGStatMonitorQAN)(nil)

agent/agents/postgres/pgstatmonitor/pgstatmonitor_models.go

@@ -34,7 +34,7 @@ var (
 	v08 = version.Must(version.NewVersion("0.8"))
 )
 
-// pgStatMonitor represents a row in pg_stat_monitor view
+// pgStatMonitor represents a row in pg_stat_monitor view.
 type pgStatMonitor struct {
 	// PGSM < 0.6.0
 	DBID   int64
@@ -348,7 +348,7 @@ func (s *pgStatMonitor) View() reform.View { //nolint:ireturn
 }
 
 var (
-	// Check interfaces
+	// Check interfaces.
 	_ reform.Struct = (*pgStatMonitor)(nil)
 	_ fmt.Stringer  = (*pgStatMonitor)(nil)
 )

agent/agents/postgres/pgstatstatements/pgstatstatements.go

@@ -423,7 +423,7 @@ func (m *PGStatStatementsQAN) Collect(ch chan<- prometheus.Metric) {
 	}
 }
 
-// check interfaces
+// check interfaces.
 var (
 	_ prometheus.Collector = (*PGStatStatementsQAN)(nil)
 )

agent/agents/postgres/pgstatstatements/utils.go

@@ -26,7 +26,7 @@ import (
 	"github.com/percona/pmm/agent/utils/truncate"
 )
 
-// statementsCache is a wrapper for cache.Cache to use only with statementsMap type
+// statementsCache is a wrapper for cache.Cache to use only with statementsMap type.
 type statementsCache struct {
 	cache *cache.Cache
 }

agent/agents/process/process.go

@@ -106,8 +106,8 @@ func (p *Process) Run(ctx context.Context) {
 	close(p.ctxDone)
 }
 
-// STARTING -> RUNNING
-// STARTING -> WAITING
+// STARTING -> RUNNING.
+// STARTING -> WAITING.
 func (p *Process) toStarting() {
 	p.l.Tracef("Process: starting.")
 	p.changes <- inventorypb.AgentStatus_STARTING
@@ -149,8 +149,8 @@ func (p *Process) toStarting() {
 	}
 }
 
-// RUNNING -> STOPPING
-// RUNNING -> WAITING
+// RUNNING -> STOPPING.
+// RUNNING -> WAITING.
 func (p *Process) toRunning() {
 	p.l.Tracef("Process: running.")
 	p.changes <- inventorypb.AgentStatus_RUNNING
@@ -166,8 +166,8 @@ func (p *Process) toRunning() {
 	}
 }
 
-// WAITING -> STARTING
-// WAITING -> DONE
+// WAITING -> STARTING.
+// WAITING -> DONE.
 func (p *Process) toWaiting() {
 	delay := p.backoff.Delay()
 
@@ -192,7 +192,7 @@ func (p *Process) toWaiting() {
 	}
 }
 
-// STOPPING -> DONE
+// STOPPING -> DONE.
 func (p *Process) toStopping() {
 	p.l.Tracef("Process: stopping (sending SIGTERM)...")
 	p.changes <- inventorypb.AgentStatus_STOPPING
@@ -235,7 +235,7 @@ func (p *Process) Logs() []string {
 	return p.pl.Latest()
 }
 
-// check interfaces
+// check interfaces.
 var (
 	_ fmt.Stringer = (*Params)(nil)
 )

agent/agents/process/process_logger.go

@@ -148,7 +148,7 @@ func extractLogLevel(line string) (logrus.Level, bool, error) {
 	return level, true, nil
 }
 
-// check interfaces
+// check interfaces.
 var (
 	_ io.Writer = (*processLogger)(nil)
 )

agent/agents/supervisor/supervisor.go

@@ -112,7 +112,7 @@ func NewSupervisor(ctx context.Context, av agentVersioner, cfg configGetter) *Su
 	}
 }
 
-// Run waits for context and stop all agents when it's done
+// Run waits for context and stop all agents when it's done.
 func (s *Supervisor) Run(ctx context.Context) {
 	<-ctx.Done()
 	s.stopAll() //nolint:contextcheck
@@ -188,7 +188,7 @@ func (s *Supervisor) AgentLogByID(id string) ([]string, uint) {
 	return nil, 0
 }
 
-// ClearChangesChannel drains state change channel
+// ClearChangesChannel drains state change channel.
 func (s *Supervisor) ClearChangesChannel() {
 	for {
 		select {
@@ -618,7 +618,7 @@ func (s *Supervisor) startBuiltin(agentID string, builtinAgent *agentpb.SetState
 	return nil
 }
 
-// agentLogger write logs to Store so can get last N
+// agentLogger write logs to Store so can get last N.
 func (s *Supervisor) agentLogger(logStore *tailog.Store) *logrus.Logger {
 	return &logrus.Logger{
 		Out:          io.MultiWriter(os.Stderr, logStore),
@@ -768,7 +768,7 @@ func (s *Supervisor) Collect(ch chan<- prometheus.Metric) {
 	}
 }
 
-// check interfaces
+// check interfaces.
 var (
 	_ prometheus.Collector = (*Supervisor)(nil)
 )