PMM-12375 do not update if version is empty

percona · Sep 19, 2023 · ac80cad · ac80cad
1 parent 8f61035
commit ac80cad
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/managed/services/agents/channel/channel.go b/managed/services/agents/channel/channel.go
@@ -201,7 +201,7 @@ func (c *Channel) send(msg *agentpb.ServerMessage) {
 	atomic.AddUint32(&c.mSent, 1)
 }
 
-// runReader receives messages from server.
+// runReceiver receives messages from server.
 func (c *Channel) runReceiver() {
 	defer func() {
 		close(c.requests)

diff --git a/managed/services/agents/service_info_broker.go b/managed/services/agents/service_info_broker.go
@@ -197,8 +197,12 @@ func updateServiceVersion(ctx context.Context, q *reform.Querier, resp agentpb.A
 	l := logger.Get(ctx)
 
 	version := resp.(*agentpb.ServiceInfoResponse).GetVersion() //nolint:forcetypeassert
-	service.Version = version
+	if version == "" {
+		return nil
+	}
+
 	l.Debugf("Updating service version: %s.", version)
+	service.Version = version
 	if err := q.Update(service); err != nil {
 		return errors.Wrap(err, "failed to update service version")
 	}