Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7: enable tests #1902

Closed
wants to merge 8 commits into from
Closed

PMM-7: enable tests #1902

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
143da80
enable tests
ritbl Mar 23, 2023
605c685
trigger ci
ritbl Mar 23, 2023
95ac85e
trigger ci
ritbl Mar 23, 2023
cdba95f
Merge branch 'main' into pmm-7-enable-tests
Sep 4, 2023
f1d4aec
PMM-7 fix the tests
Sep 4, 2023
b6b38be
PMM-7 fix trailing comma
Sep 4, 2023
13bed14
Merge branch 'main' into pmm-7-enable-tests
BupycHuk Oct 6, 2023
534a94a
Merge branch 'main' into pmm-7-enable-tests
ademidoff Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions managed/services/supervisord/logs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ var commonExpectedFiles = []string{
"postgresql14.log",
"qan-api2.ini",
"qan-api2.log",
"supervisorctl_status.log",
"supervisord.conf",
"supervisord.log",
"victoriametrics-promscrape.yml",
Expand Down Expand Up @@ -120,8 +121,6 @@ func TestReadLog(t *testing.T) {
}

func TestAddAdminSummary(t *testing.T) {
t.Skip("FIXME")

zipfile, err := os.CreateTemp("", "*-test.zip")
assert.NoError(t, err)

Expand Down Expand Up @@ -173,9 +172,11 @@ func TestFiles(t *testing.T) {
continue
}

if f.Name == "supervisorctl_status.log" {
// FIXME: this fails following the transition to EL9
continue
if f.Name != "supervisorctl_status.log" {
// Note: following the transition to EL9 querying this file generates an error. No workaround is available ATM.
assert.NoError(t, f.Err, "name = %q", f.Name)
} else {
assert.EqualError(t, f.Err, "exit status 3")
}

assert.NoError(t, f.Err, "name = %q", f.Name)
Expand All @@ -188,8 +189,6 @@ func TestFiles(t *testing.T) {
}

func TestZip(t *testing.T) {
t.Skip("FIXME")

checker := NewPMMUpdateChecker(logrus.WithField("test", t.Name()))
params, err := models.NewVictoriaMetricsParams(models.BasePrometheusConfigPath, models.VMBaseURL)
require.NoError(t, err)
Expand Down
Loading